Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url instead of issue number #32

Open
Ana06 opened this issue May 3, 2019 · 1 comment
Open

url instead of issue number #32

Ana06 opened this issue May 3, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@Ana06
Copy link
Collaborator

Ana06 commented May 3, 2019

I find in general a good practise to write in the commit message

Closes https://github.com/RomuloOliveira/commit-messages-guide/issues/32

Instead of

Closes #32

What do do you think? should we update this in the guide?

@RomuloOliveira RomuloOliveira added the enhancement New feature or request label May 7, 2019
@RomuloOliveira
Copy link
Owner

@Ana06 I think it's a good idea to include both ways and discuss them (e.g., one is easy and straightforward to write and the other is better when using git log).

I'll add the enhancement label to this issue. Unfortunately, I haven't took the time I wanted to improve some things (I didn't forget #5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants