Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not support JDK 17 LTS #327

Open
TinyZzh opened this issue Aug 2, 2022 · 12 comments
Open

Not support JDK 17 LTS #327

TinyZzh opened this issue Aug 2, 2022 · 12 comments

Comments

@TinyZzh
Copy link

TinyZzh commented Aug 2, 2022

image

@TinyZzh
Copy link
Author

TinyZzh commented Aug 2, 2022

version: 3.0.3-jdk17

@TinyZzh
Copy link
Author

TinyZzh commented Aug 2, 2022

image
image

@istinnstudio
Copy link

one or more runtime commands like this one should work..
--add-opens=java.base/java.lang=ALL-UNNAMED

Strong Encapsulation in the JDK Java 17 LTS
#312

@MikhailPigolkin
Copy link

2022-09-23_12-54-44
Why doesn't it work on the simplest example? I use jdk 17 with
--add-opens=java.base/java.lang=ALL-UNNAMED

@MikhailPigolkin
Copy link

2022-09-23_12-54-44 Why doesn't it work on the simplest example? I use jdk 17 with --add-opens=java.base/java.lang=ALL-UNNAMED

everything works fine on 1.8....

@durandal1981
Copy link

I also run in jdk17 with --add-opens=java.base/java.lang=ALL-UNNAMED,
but it's also has the problem

@istinnstudio
Copy link

istinnstudio commented Oct 7, 2022

This is the run commands I use, but those are related to my project

--add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.math=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.text=ALL-UNNAMED --add-opens=java.sql/java.sql=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/sun.nio=ALL-UNNAMED --add-opens=java.desktop/java.awt.geom=ALL-UNNAMED --add-opens=java.desktop/sun.awt.shell=ALL-UNNAMED --add-opens=java.desktop/java.awt=ALL-UNNAMED --add-exports=java.desktop/sun.awt.image=ALL-UNNAMED --add-opens=java.base/java.lang.reflect=ALL-UNNAMED

@f0def
Copy link

f0def commented Oct 8, 2022

We're using 3.0.3-jdk17. And it doesn't work without these JVM arguments (related for our requirements):

--add-opens=java.base/java.time=ALL-UNNAMED
--add-opens=java.base/java.lang=ALL-UNNAMED
--add-opens=java.base/java.math=ALL-UNNAMED
--add-opens=java.base/java.util=ALL-UNNAMED
--add-opens=java.base/java.util.concurrent=ALL-UNNAMED
--add-opens=java.base/java.net=ALL-UNNAMED
--add-opens=java.base/java.text=ALL-UNNAMED
--add-opens=java.sql/java.sql=ALL-UNNAMED

@istinnstudio
Copy link

istinnstudio commented Oct 8, 2022

I am not familiar with the internals of FST, but luckily I use with much of success the 2.57 version with the latest java-17 additions from 3.0.3-jdk17 branch. Some other selected pull requests added also, I do not know what bugs or side effects this might rise.

edit:
Here is a link to sources: [2.57-jdk17-backport-experimental]
(https://github.com/istinnstudio/fast-serialization-2.57-java17)

A fork to include those mods for those who might find it useful. I use 2.57 because 3.0 version breaks all my serialized files and for the time being I am too lazy to write a mass file converter (as suggested by author). Use it with extreme caution.

@ndrsf
Copy link

ndrsf commented Oct 19, 2022

I tried to make it as easy as possible to use FST with Java 17 using a small example project: https://github.com/ndrsf/fst-java17
But I didn't find a production-ready way to use FST without passing the JVM parameters.

@lmeinen
Copy link

lmeinen commented Jun 15, 2023

Any updates on this issue? Using version 3.0.4-jdk17 doesn't appear to help.

@istinnstudio
Copy link

I do not think there is an other way other than "--add-opens" and probably it will stay this way for ever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants