Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checking that cargo exists when building gccrs #2881

Open
CohenArthur opened this issue Feb 27, 2024 · 3 comments · May be fixed by #2942
Open

Add checking that cargo exists when building gccrs #2881

CohenArthur opened this issue Feb 27, 2024 · 3 comments · May be fixed by #2942
Labels
bug misc

Comments

@CohenArthur
Copy link
Member

Add checking for the existence of cargo when building gccrs, erroring out nice and early if it is not present - this will improve the user experience now that we rely on Rust components.
@tschwinge
Copy link
Member

This is in context of #2822 "Start reusing rustc's format_args parser".

I'm actually curious: is it really erroring out, or is it degraded functionality?

@CohenArthur
Copy link
Member Author

it's erroring out properly, but mjw suggested adding that check to cut out the compilation earlier in case cargo isn't present. it will make the experience better

@tschwinge tschwinge mentioned this issue Mar 26, 2024
Closed
@CohenArthur
Copy link
Member Author

https://www.gnu.org/software/autoconf/manual/autoconf-2.60/html_node/Generic-Programs.html

@P-E-P P-E-P mentioned this issue Apr 3, 2024
Closed
@tschwinge tschwinge linked a pull request Apr 7, 2024 that will close this issue
Check for cargo when building rust language #2942
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug misc
Projects
None yet
Milestone
No milestone
2 participants
@tschwinge @CohenArthur