Modify test cfg1.rs for name resolution 2.0
#3208
Draft
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc/testsuite/ChangeLog: * rust/compile/cfg1.rs: Run test with name resolution 2.0 only and adjust expected error message. * rust/compile/nr2/exclude: Remove cfg1.rs. Signed-off-by: Owen Avery <[email protected]>
|
Going to turn this into a draft |
CohenArthur
reviewed
Oct 24, 2024
There was a problem hiding this comment.
since this is a cfg testcase, I think it's fair to duplicate it for now and add the -frust-name-resolution2.0 option to the duplicate. IMO we should get all testcases working, then switch to NR2.0 by default, then delete the "original NR1" testcases and replace them with the duplicates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks
cfg1.rsso that it passes with name resolution 2.0. As an alternative we could modify the error message emitted by name resolution 2.0 to match that emitted by name resolution 1.0, or to match that emitted by rustc.