rust: Inline format args #1030
rust: Inline format args #1030
Conversation
A minor Rust cleanup to inline `format!("{}", foo)` and similar macro calls into `format!("{foo}")`.
While mostly cosmetic, this change makes it a bit easier to read format argument strings, shortens code, and makes it easier to see cases with double-referencing values causing minor performance (apparently `&foo` in a format! causes about 6% perf cost due to Rust compiler being unable to inline it due to dynamic invocation.
nyurik
force-pushed
the
rust_inline_fmt_arg
branch
from
38d7c94
to
c23e18f
Compare
|
Thanks for the PR! Development/changes should be submitted to the mailing list (please see https://rust-for-linux.com/contributing). |
|
Thanks @ojeda, I tried looking through all those numerous guides and got really lost. Is there a simple short tutorial that walks one step by step with as little text as possible? As someone once said, it is simple to explain something in a difficult way, but it is very difficult to explain it simply :) |
|
My pleasure Yuri! Yeah, it can be a bit overwhelming at first. In the webpage I give a pointer to If something does not seem to work, then please feel free to ask in e.g. our Zulip for help on the process. |
A minor Rust cleanup to inline
format!("foo={}", foo)and similar macro calls intoformat!("foo={foo}").While mostly cosmetic, this change makes it a bit easier to read format argument strings, shortens code, and makes it easier to see cases with double-referencing values causing minor performance (apparently
&fooin a format! causes about 6% perf cost due to Rust compiler being unable to inline it due to dynamic invocation.