Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idea of implementing AGC (Automatic Gain Control) #620

Closed
UnknownSuperficialNight opened this issue Sep 25, 2024 · 1 comment · Fixed by #621
Closed

Idea of implementing AGC (Automatic Gain Control) #620

UnknownSuperficialNight opened this issue Sep 25, 2024 · 1 comment · Fixed by #621
Labels
enhancement

Comments

@UnknownSuperficialNight
Copy link
Contributor

I was thinking for the sink: would you be okay with me looking into making a pull request for implementing AGC for the sink? This would allow it to dynamically adjust the audio volume by increasing the gain if the audio level is too low or decreasing it if the level is too high.

Apologies if this is already implemented somewhere; I checked the documentation but could not find a mention of it.
@dvdsk
Copy link
Collaborator

dvdsk commented Sep 25, 2024

Thats a pretty cool idea 👍 , I would love to have it!

I suggest making a Source instead of modifying the Sink. A source is easier to test and would allow users to use automatic gain control even if they do not use the Sink.

Take a look at the Source trait docs . A good example Source too look at would be the amplify Source.

Feel free to make a PR, it does not need to be done if you open it as draft I'll take a look every once in a while and see if I can drop some feedback/help out.

Merged
@dvdsk dvdsk closed this as completed in #621 Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Automatic Gain Control UnknownSuperficialNight/rodio
2 participants
@dvdsk @UnknownSuperficialNight