Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion about using the SDK validator for CI #19

Open
MirkoCovizzi opened this issue May 4, 2020 · 1 comment
Open

Discussion about using the SDK validator for CI #19

MirkoCovizzi opened this issue May 4, 2020 · 1 comment

Comments

@MirkoCovizzi
Copy link
Member

MirkoCovizzi commented May 4, 2020

I was thinking about using the validator from the SDK to guarantee that, by testing the examples, between PRs there are no protocol breakages.
What's the best way to approach this? I'm not a fan of adding pre-compiled executables and use those for the validation, so the alternative would be to separately compile them as needed through some workflow.

What's your opinion on this @m-hilgendorf ?

@m-hilgendorf
Copy link
Member

The "proper" approach to this is to run a GH action that checks out the VST3 SDK repo, builds the validator from source, and caches the build artifacts to run it (using actions/cache or similar).

Another thing we can do is just host the validator binaries somewhere, since the SDK is big and building takes a long time, and I think caches are refreshed from time to time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants