Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiftoverError - null value in column "conversion_tool" #1186

Open
davmlaw opened this issue Oct 23, 2024 · 1 comment
Open

LiftoverError - null value in column "conversion_tool" #1186

davmlaw opened this issue Oct 23, 2024 · 1 comment

Comments

@davmlaw
Copy link
Contributor

davmlaw commented Oct 23, 2024

View details in Rollbar: https://app.rollbar.com/a/jimmy.andrews/fix/item/VariantGrid/5459

  File "/opt/variantgrid/classification/tasks/classification_import_process_variants_task.py", line 114, in liftover_classification_import
    create_liftover_pipelines(classification_import.user, allele_qs, import_source, genome_build)
  File "/opt/variantgrid/snpdb/liftover.py", line 48, in create_liftover_pipelines
    liftover = LiftoverRun.objects.create(user=user,

NotNullViolation: null value in column "conversion_tool" of relation "snpdb_liftoverrun" violates not-null constraint
DETAIL:  Failing row contains (4823, 2024-10-23 03:11:08.790847+00, 2024-10-23 03:11:08.791004+00, null, null, GRCh38, 2, null, null).
@davmlaw davmlaw changed the title IntegrityError: null value in column "conversion_tool" of relation "snpdb_liftoverrun" violates not-null constraint DETAIL: Failing row contains (4779, 2024-10-23 03:06:26.637843+00, 2024-10-23 03:06:26.637865+00, null, null, GRCh38, 2, null, null). LiftoverError - null value in column "conversion_tool" Oct 23, 2024
@davmlaw
Copy link
Contributor Author

davmlaw commented Oct 23, 2024

I think I went back and forth making a method a return vs yield and ended up yielding None rather than nothing

liftover._liftover_using_source_variant_coordinate starts with setting conversion_tool = None

Then we loop through and try and find way to liftover (just BCFTools)

If nothing found, then conversion_tool left as None

This eventually causes trouble as build_liftover_allele_variant_coordinate_error in create_liftover_pipelines has entry where convert_tool is None, then dies when trying to create LiftoverRun.conversion_tool = None

Solution is to just not yield anything from _liftover_using_source_variant_coordinate

davmlaw added a commit that referenced this issue Oct 23, 2024
TheMadBug pushed a commit that referenced this issue Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant