Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dialog is new but not highlighted as such #127

Closed
o-liver opened this issue Jun 5, 2024 · 2 comments
Closed

The dialog is new but not highlighted as such #127

o-liver opened this issue Jun 5, 2024 · 2 comments
Assignees
Labels
contribution Valuable Contribution size/s Requires minimal effort to get changed. type/examples-samples Related to existing examples/samples, or request for new examples/samples.

Comments

@o-liver
Copy link
Contributor

o-liver commented Jun 5, 2024

In the code changes for the webapp/controller/HelloPanel.controller.ts the private dialog: Dialog; statement is not highlighted in yellow, even though it is a new change in regards to the previous step.

https://github.com/SAP-docs/sapui5/blame/e91c998501a959ac766536e81a537ea6916bec80/docs/03_Get-Started/step-16-dialogs-and-fragments-typescript-4b2e306.md#L75

@KvM2
Copy link
Contributor

KvM2 commented Jun 5, 2024

Hi @o-liver, thanks for your contribution! We'll look into it and will get back to you.

@KlattG KlattG added contribution Valuable Contribution size/s Requires minimal effort to get changed. type/examples-samples Related to existing examples/samples, or request for new examples/samples. labels Jun 5, 2024
@KlattG
Copy link
Contributor

KlattG commented Jun 5, 2024

Fixed from UI5 1.125

@KlattG KlattG closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution size/s Requires minimal effort to get changed. type/examples-samples Related to existing examples/samples, or request for new examples/samples.
Projects
None yet
Development

No branches or pull requests

3 participants