Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller Code for Sample Input Checked does not work #37

Closed
sebastianesch opened this issue Jan 31, 2023 · 4 comments
Closed

Controller Code for Sample Input Checked does not work #37

sebastianesch opened this issue Jan 31, 2023 · 4 comments
Assignees
Labels
contribution Valuable Contribution follow-up-with/dev Clarification with development needed. type/examples-samples Related to existing examples/samples, or request for new examples/samples.

Comments

@sebastianesch
Copy link
Contributor

Hi,

the sample for Input - Checked (https://ui5.sap.com/#/entity/sap.m.Input/sample/sap.m.sample.InputChecked) does not work.

In the Controller code https://ui5.sap.com/#/entity/sap.m.Input/sample/sap.m.sample.InputChecked/code/C.controller.js the function _validateInput needs to be corrected from:

_validateInput: function (oInput) {
	var sValueState = "None";
	var bValidationError = false;
	var oBinding = oInput.getBinding("value");

	try {
		oBinding.getType().validateValue(oInput.getValue());
	} catch (oException) {
		sValueState = "Error";
		bValidationError = true;
	}

	oInput.setValueState(sValueState);

	return bValidationError;
},

to:

_validateInput: function (oInput) {
	var sValueState = "None";
	var bValidationError = false;
	var oBindingInfo = oInput.getBindingInfo("value");

	try {
		oBindingInfo.type.validateValue(oInput.getValue());
	} catch (oException) {
		sValueState = "Error";
		bValidationError = true;
	}

	oInput.setValueState(sValueState);

	return bValidationError;
},

Kind regards,
Sebastian

@KvM2 KvM2 added the follow-up-with/dev Clarification with development needed. label Jan 31, 2023
@KvM2
Copy link
Contributor

KvM2 commented Jan 31, 2023

Hi @sebastianesch, thanks for your contribution. We appreciate it and will look into this.

@simonarangelova
Copy link
Contributor

Hello,

After discussing this with the team, I have moved the issue to the OpenUI5 repository, as it is not related to documentation.

Thank you

@boghyon
Copy link
Contributor

boghyon commented Feb 6, 2023

@sebastianesch Let's continue at SAP/openui5#3693

@OlMue OlMue added the contribution Valuable Contribution label Nov 22, 2023
Copy link

sap-doc-bot bot commented Nov 22, 2023

Thank you for your valuable feedback contribution, @sebastianesch! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

@OlMue OlMue added the type/examples-samples Related to existing examples/samples, or request for new examples/samples. label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution follow-up-with/dev Clarification with development needed. type/examples-samples Related to existing examples/samples, or request for new examples/samples.
Projects
None yet
Development

No branches or pull requests

5 participants