Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document adaptation project's appdescriptor 'validAppVersions' settings #39

Closed
piejanssens opened this issue Feb 8, 2023 · 5 comments
Closed
Assignees
Labels
follow-up-with/dev Clarification with development needed. not-doc-issue Reported issue is not a documentation issue. SAP Fiori elements

Comments

@piejanssens
Copy link

piejanssens commented Feb 8, 2023

A mismatch between the through BAS generated Adaptation Project's manifest.appdescr settings on validAppVersions and the sap.app/id version after a SP update caused the application to stop functioning.
The fact that it no longer worked in itself is of course not an issue, but the fact that it was automatically locked to that version in combination with a lack of documentation. It was hard to figure out why the extension's logic was not being invoked.

We looked for documentation on these settings but could not find any!

 "validAppVersions": {
        "creation": "1.0.126",
        "from": "1.0.126",
        "to": "1.0.126"
}

In particular, we need to know if we leave out minor and/or patch levels from the version targets.

Related to: docs/06_SAP_Fiori_Elements/extending-delivered-apps-using-adaptation-extensions-52fc48b.md

@KvM2
Copy link
Contributor

KvM2 commented Feb 8, 2023

Hi @piejanssens , thanks for your contribution. We appreciate it and will look into this.

@KvM2 KvM2 added the follow-up-with/dev Clarification with development needed. label Feb 8, 2023
@mishuagrawal
Copy link
Contributor

Hello @piejanssens ,

Thank you for your patience. We are looking into this issue and get back to you as soon as possible. Apologies for the delay.

@mishuagrawal
Copy link
Contributor

Hello,

Please accept my sincere apologies for the delay in responding and updating this issue. I understand that your concern was not resolved.

We have discussed it in length with our dev team and they have requested that you can create an incident using the component CA-UI5-FL-ADP-BAS. This is the component for adaptation project in BAS. Please go ahead and raise a concern using this component.

I will now go ahead and close this issue. If in case you have any further concerns, please feel free to write back to us.

Thanks and regards,
Mishu Agrawal

@gyoung111
Copy link

HI Team,
This issue hugely impact customer. We use BAS to do the adaptation extension and every time, note version updated, the extension disappeared due to mis-matched. We cant expect customer to re-do the extension again and again very time there is new note with new version though the changes is not part of the extension we did. SAP could you please take notes of this please? This is important. Thank you

@mishuagrawal
Copy link
Contributor

Hello,

Thank you for writing back to us. Unfortunately, I wont be of much help to you here. These repository and the issues are for any concerns with our UI5 documentation. I can completely understand your concern and would like to help you.

As mentioned in my previous comment, kindly reach out to the BAS team directly using the component CA-UI5-FL-ADP-BAS. Kindly create an incident. You will get help directly from the BAS team.

I hope this is of help to you.

Thanks and regards,
Mishu Agrawal

@OlMue OlMue added the invalid This doesn't seem right label Nov 22, 2023
@OlMue OlMue added not-doc-issue Reported issue is not a documentation issue. and removed invalid This doesn't seem right labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
follow-up-with/dev Clarification with development needed. not-doc-issue Reported issue is not a documentation issue. SAP Fiori elements
Projects
None yet
Development

No branches or pull requests

5 participants