Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code sample full of   #45

Closed
marianfoo opened this issue Mar 13, 2023 · 6 comments
Closed

Code sample full of   #45

marianfoo opened this issue Mar 13, 2023 · 6 comments
Assignees
Labels
contribution Valuable Contribution mission-award SAP Community mission award SAP Fiori elements type/examples-samples Related to existing examples/samples, or request for new examples/samples.

Comments

@marianfoo
Copy link
Contributor

https://sapui5.hana.ondemand.com/sdk/#/topic/02fb273ee1024fec914b11befe2b1887

can´t attach a screenshot currently, so here is the faulty sample

"card007_ProductsOutOfStock": {
  "model": "salesOrder",
  "template": "sap.ovp.cards.stack",
  "settings": {
    "itemText": "{{stackCard_itemText}}",
    "title": "Products Out of Stock",
    "subTitle": "SalesOrderSet Stack Card",
    "requireAppAuthorization": "#Action-toappnavsample",
    "entitySet": "SalesOrderSet",
    "identificationAnnotationPath": "com.sap.vocabularies.UI.v1.Identification,com.sap.vocabularies.UI.v1.Identification#item2",
    "objectStreamCardsSettings": {
      "showFirstActionInFooter": false,
      "customActions": [
        {
          "text": "text1",
          "press": "press1",
          "position": 1
        },
        {
          "text": "text2",
          "press": "press2",
          "position": 10
        },
        {
          "text": "text3",
          "press": "press1",
          "position": 3
        },
        {
          "text": "text4",
          "press": "press2",
          "position": 8
        },
        {
          "text": "text5",
          "press": "press1",
          "position": 5
        },
        {
          "text": "text6",
          "press": "press2",
          "position": 6
        }
      ]
    }
  }
}, 
@DavidMitreski5
Copy link

Hi @marianfoo, Thank you for your feedback! We’ll look into it and come back to you if we have any questions.

@KvM2
Copy link
Contributor

KvM2 commented Mar 24, 2023

This is actually an FE topic. I reassigned it now.

@KvM2 KvM2 assigned JannaLisa and unassigned KlattG Mar 24, 2023
@JannaLisa
Copy link
Contributor

Hi @marianfoo ,
just a quick update: this awful rendering of the sample seems to have occurred with version 1.110 - without us having changed anything. So since I'm unable to identify any cause, the only thing I can do is manually correct the sample code again.
The corrected version will be visible with release 1.113, since release 1.112 has already been closed.
Thanks for spotting this.
Best regards,
JannaLisa

@OlMue
Copy link
Contributor

OlMue commented Mar 30, 2023

Closing this since it's solved. Thanks again, @marianfoo!

@OlMue OlMue closed this as completed Mar 30, 2023
@OlMue OlMue added the contribution Valuable Contribution label Nov 22, 2023
Copy link

sap-doc-bot bot commented Nov 22, 2023

Thank you for your valuable feedback contribution, @marianfoo! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

@OlMue OlMue added the type/examples-samples Related to existing examples/samples, or request for new examples/samples. label Nov 24, 2023
@marianfoo
Copy link
Contributor Author

@qmacro qmacro added the mission-award SAP Community mission award label Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution mission-award SAP Community mission award SAP Fiori elements type/examples-samples Related to existing examples/samples, or request for new examples/samples.
Projects
None yet
Development

No branches or pull requests

7 participants