Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample: Walkthrough - Step 26 - Mock Server Configuration - Issue in downloaded file "mockServer.html" #93

Closed
micbez opened this issue Nov 13, 2023 · 3 comments
Assignees
Labels
contribution Valuable Contribution follow-up-with/dev Clarification with development needed. type/examples-samples Related to existing examples/samples, or request for new examples/samples.

Comments

@micbez
Copy link

micbez commented Nov 13, 2023

Issue description

Hi colleagues,

during my Walkthrough exercise (Step 26) I've downloaded complete source code of this exercise. I've realized issue in downloaded file mockServer.html in attribute src. Downloaded file contains wrong value "resources/sap-ui-core.js", but I assume the right value is "../resources/sap-ui-core.js". You can check it against source code for mockServer.html displayed directly at this Walkthrough exercise. With wrong value in the code I was not able to run the exercise.

Thank you for double checking and correction :)

Kind regards
Michal

@OlMue
Copy link
Contributor

OlMue commented Nov 13, 2023

Hi @micbez, thanks for letting us know, we'll look into this.

@KlattG
Copy link
Contributor

KlattG commented Nov 14, 2023

The issue has been fixed with UI5 1.120.1

@KlattG KlattG closed this as completed Nov 14, 2023
@OlMue OlMue added contribution Valuable Contribution follow-up-with/dev Clarification with development needed. labels Nov 22, 2023
Copy link

sap-doc-bot bot commented Nov 22, 2023

Thank you for your valuable feedback contribution, @micbez! So that we can recognize your contribution in SAP Community, please tell us your SAP Community profile URL in a reply to this comment; don't include any other text, just the URL on its own, like this:

https://people.sap.com/your-user-name

Thanks!

@OlMue OlMue added type/content-gaps Something essential is missing in the documentation. type/examples-samples Related to existing examples/samples, or request for new examples/samples. and removed type/content-gaps Something essential is missing in the documentation. labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution follow-up-with/dev Clarification with development needed. type/examples-samples Related to existing examples/samples, or request for new examples/samples.
Projects
None yet
Development

No branches or pull requests

3 participants