Skip to content

Latest commit

 

History

History
145 lines (117 loc) · 4.12 KB

IfBlockAtLoopEndRule.md

File metadata and controls

145 lines (117 loc) · 4.12 KB
Raw

<-- previous rule | overview | next rule -->

Replace long IF blocks at loop end

Replaces long IF blocks at loop end with IF NOT ... CONTINUE to decrease nesting depth, prefering early exit to overdoing structured programming.

References

Options

  • Replace IF blocks with at least [10] lines
  • and a share of at least [50] % of all lines
  • Keep IF blocks that contain exceptional logic (RAISE, MESSAGE, RETURN, EXIT)
  • Negate logical expressions with NOT ( ... ): [if multiple inner negations (IS NOT, <>, ...) can be avoided]
  • Convert abap_false <-> abap_true (assuming abap_undefined is never used)
  • Add empty line after ENDIF

Examples

  METHOD replace_if_block_at_loop_end.
    DATA lv_count TYPE i.
    DATA lv_value TYPE i.
    
    WHILE lv_count > 0.
      lv_count -= 1.
      IF lv_count MOD 2 = 0.
        LOOP AT its_table INTO DATA(ls_row).
          " if the row was already processed, there is nothing to do. 
          IF ls_row-processed = abap_false.
            IF ls_row-another_component = abap_true.
              " if the row was not yet processed, there's so much to do!
              lv_value = 1.
              lv_value = 2.
              lv_value = 3.
              lv_value = 4.
              lv_value = 5.
              lv_value = 6.
              lv_value = 7.
              lv_value = 8.
              lv_value = 9.
              ls_row-processed = abap_true.
            ENDIF.
          ENDIF.
        ENDLOOP.
      ENDIF.
    ENDWHILE.
  ENDMETHOD.


  METHOD replace_if_block_at_loop_end_2.
    DATA lv_count TYPE i.
    DATA lv_value TYPE i.
    
    WHILE lv_count > 0.
      lv_count -= 1.
      IF lv_count MOD 2 = 0.
        LOOP AT its_table INTO DATA(ls_row).
          " if the row was already processed, there is nothing to do. 
          IF ls_row-processed = abap_false.
            " if the row was not yet processed, there's so much to do!
            lv_value = 1.
            lv_value = 2.
            lv_value = 3.
            ls_row-processed = abap_true.
          ENDIF.
        ENDLOOP.
      ENDIF.
    ENDWHILE.
  ENDMETHOD.

Resulting code:

  METHOD replace_if_block_at_loop_end.
    DATA lv_count TYPE i.
    DATA lv_value TYPE i.

    WHILE lv_count > 0.
      lv_count -= 1.
      IF lv_count MOD 2 <> 0.
        CONTINUE.
      ENDIF.

      LOOP AT its_table INTO DATA(ls_row).
        " if the row was already processed, there is nothing to do. 
        IF ls_row-processed = abap_true.
          CONTINUE.
        ENDIF.

        IF ls_row-another_component = abap_false.
          CONTINUE.
        ENDIF.

        " if the row was not yet processed, there's so much to do!
        lv_value = 1.
        lv_value = 2.
        lv_value = 3.
        lv_value = 4.
        lv_value = 5.
        lv_value = 6.
        lv_value = 7.
        lv_value = 8.
        lv_value = 9.
        ls_row-processed = abap_true.
      ENDLOOP.
    ENDWHILE.
  ENDMETHOD.


  METHOD replace_if_block_at_loop_end_2.
    DATA lv_count TYPE i.
    DATA lv_value TYPE i.

    WHILE lv_count > 0.
      lv_count -= 1.
      IF lv_count MOD 2 <> 0.
        CONTINUE.
      ENDIF.

      LOOP AT its_table INTO DATA(ls_row).
        " if the row was already processed, there is nothing to do. 
        IF ls_row-processed = abap_false.
          " if the row was not yet processed, there's so much to do!
          lv_value = 1.
          lv_value = 2.
          lv_value = 3.
          ls_row-processed = abap_true.
        ENDIF.
      ENDLOOP.
    ENDWHILE.
  ENDMETHOD.

Related code