Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong formatting for keyword DEFAULT in CORRESPONDING ... MAPPING #102

Closed
AlexMFrank opened this issue Sep 6, 2023 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@AlexMFrank
Copy link

Hi,

The keyword DEFAULT in CORRESPONDING ... MAPPING gets lower cased when using ABAP Cleaner. Pretty Printer would then upper case it again, if you use it after ABAP Cleaner.
The following code:

FINAL(p1) = VALUE I_Plant( Plant = '0001' ).
FINAL(p2) = CORRESPONDING I_Plant( p1 MAPPING PlantSupplier = DEFAULT '1234567890' ).

gets formatted by ABAP Cleaner to:

FINAL(p1) = VALUE I_Plant( Plant = '0001' ).
FINAL(p2) = CORRESPONDING I_Plant( p1 MAPPING PlantSupplier = default '1234567890' ).

I've used the latest ABAP Cleaner version 1.5.3 with the default profile.

@jmgrassau jmgrassau added the bug Something isn't working label Sep 22, 2023
@jmgrassau jmgrassau self-assigned this Sep 22, 2023
@jmgrassau
Copy link
Member

Hi Alex,

thanks a lot for reporting this! Apparently this happened because the ABAP grammar file included in ABAP cleaner was outdated. Will fix this in the next ABAP cleaner release!

Kind regards,
Jörg-Michael

jmgrassau added a commit to jmgrassau/abap-cleaner that referenced this issue Sep 22, 2023
jmgrassau added a commit that referenced this issue Sep 22, 2023
@jmgrassau
Copy link
Member

Hi Alex,

thanks again for reporting this – this should now be fixed in version 1.5.4 which was just released and contains the current ABAP grammar!

Kind regards,
Jörg-Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants