Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display issues in Dark theme after changing option of rule Standardize CLASS ... DEFINITION #179

Closed
bnichell opened this issue Oct 31, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@bnichell
Copy link

bnichell commented Oct 31, 2023

When the Dark theme is active, changing any option of rule Standardize CLASS ... DEFINITION leads to the background of the options being set to the same color as the text and thus the text is no longer readable.
The issue can be resolved by reopening the rule.

Other themes are not affected.

Before changing any option:
image

After changing any option:
image

@bnichell bnichell changed the title Display issues after changing option of rule Standardize CLASS ... DEFINITION Display issues in Dark theme after changing option of rule Standardize CLASS ... DEFINITION Oct 31, 2023
@jmgrassau jmgrassau added the bug Something isn't working label Oct 31, 2023
@jmgrassau jmgrassau self-assigned this Oct 31, 2023
@jmgrassau
Copy link
Member

Hi Benedikt,

this issue is really haunting me, or to quote Mark Twain (sort of): "This problem is easy to resolve, I have myself done it a hundred times…"

But it will be fixed with the next release. The issue was that the label "For multi-liners …" (a control that is never used in the other rules) caused a layout event before the background color could correctly be retrieved; then the default (i.e. light theme) background color was returned by the control, and when the options were changed, setBackground() caused the light theme background to be shown.

Kind regards,
Jörg-Michael

@bnichell
Copy link
Author

Hi Jörg-Michael,

supporting multi themes is always a pain, tell me about it... Thanks for the quick fix.

Cheers,
Benedikt

jmgrassau added a commit to jmgrassau/abap-cleaner that referenced this issue Nov 1, 2023
@jmgrassau
Copy link
Member

Hi Benedikt,

thanks again for reporting this bug – it should be fixed (and hopefully never come up again!) in version 1.10.0, which was just released!

Kind regards,
Jörg-Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants