Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align keywords with second word of first line: CALL TRANSFORMATION #22

Closed
ConjuringCoffee opened this issue May 24, 2023 · 4 comments
Closed

Align keywords with second word of first line: CALL TRANSFORMATION #22

ConjuringCoffee opened this issue May 24, 2023 · 4 comments
Assignees
@jmgrassau
Labels
bug Something isn't working

Comments

@ConjuringCoffee
Copy link
Contributor

ConjuringCoffee commented May 24, 2023 •
edited
Loading

The rule "Align keywords with second word of first line" doesn't do anything for the command CALL TRANSFORMATION:

CALL TRANSFORMATION ztest
  SOURCE XML iv_xml
  RESULT urlrequest = rv_request.

Expected result:

CALL TRANSFORMATION ztest
     SOURCE XML iv_xml
     RESULT urlrequest = rv_request.
@jmgrassau jmgrassau added the bug Something isn't working label May 25, 2023
@jmgrassau
Copy link
Member

Hi ConjuringCoffee,

that's a good point – I did intend to exclude "CALL METHOD" from this rule (because there is a dedicated alignment rule for that), but CALL TRANSFORMATION could indeed be included. That should be easy to fix.

Kind regards,
Jörg-Michael

@ConjuringCoffee
Copy link
Contributor Author

That's great to hear, thanks for the great work you do here!

@jmgrassau jmgrassau self-assigned this May 25, 2023
jmgrassau added a commit to jmgrassau/abap-cleaner that referenced this issue May 25, 2023
@jmgrassau
fix AlignWithSecondWordRule for CALL TRANSFORMATION (SAP#22)
36c4330
jmgrassau added a commit that referenced this issue May 25, 2023
@jmgrassau
fix AlignWithSecondWordRule for CALL TRANSFORMATION (#22)
1a440db
@jmgrassau
Copy link
Member

Hi ConjuringCoffee,

this, too, should now be resolved in the new release (version 1.2.1)!

Kind regards,
Jörg-Michael

@ConjuringCoffee
Copy link
Contributor Author

I can confirm that it works - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmgrassau jmgrassau

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ConjuringCoffee @jmgrassau