Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight of opened rule is very weak in dark mode #282

Open
ConjuringCoffee opened this issue Mar 25, 2024 · 2 comments
Open

Highlight of opened rule is very weak in dark mode #282

ConjuringCoffee opened this issue Mar 25, 2024 · 2 comments

Comments

@ConjuringCoffee
Copy link
Contributor

ConjuringCoffee commented Mar 25, 2024

Hi Jörg-Michael, I find that the indicator for a currently opened rule is very weak (after clicking into the examples or options). I sometimes find myself lost in the list of rules because of that!

I've had a look at the documentation, and it seems like this is how it looks like in light mode:

image

However, here's how it looks like in dark mode (selecting the rule and then clicking into the examples or options):
image

Can you still see it? 😉

This is especially disorienting when working with the highlight functionality. Here's how it looks like before selecting it:

image

Here's what it looks like after selecting it:

image

Then clicking into the options or examples:

image

It would be great if the green highlight was still discernable after selecting the rule.

@jmgrassau
Copy link
Member

Hi ConjuringCoffee,

no, I can't see it… good point! And anyway, I wonder whether background colors shouldn't be reworked altogether (including in the light theme, where IMHO, they could be a bit less prominent – sometimes, all is just yellow…), possibly adding an option to the View menu to make colors either more striking or more low-key.

Kind regards,
Jörg-Michael

@jmgrassau
Copy link
Member

Hi ConjuringCoffee,

I experimented a bit here, but it seems that while I can set the basic background color for each of these list items, the rest is done by the OS – both the blueish background when selecting the item, and the black background for the selected item when the focus is moved away. As of now, I didn't manage to override that. How to change SWT Table Item selection background color sounded promising, but I didn't get that running. Any Java / SWT wizards out there?

Kind regards,
Jörg-Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants