Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the usage of "readonly" modifier for constructor parameters #6121

Closed
2 tasks
InnaAtanasova opened this issue Jul 28, 2021 · 0 comments
Closed
2 tasks
Labels
core Core library specific issues platform platform
Milestone

Comments

@InnaAtanasova
Copy link
Contributor

Currently we have both cases:

private readonly _elRef: ElementRef,
private readonly _cdr: ChangeDetectorRef,
@Optional() private readonly _rtlService: RtlService

and

private  _elRef: ElementRef,
private  _cdr: ChangeDetectorRef,
@Optional() private  _rtlService: RtlService

We need to:

  • agree on the unified approach
  • change all occurrences in the project - Core and Platform
@InnaAtanasova InnaAtanasova added platform platform core Core library specific issues labels Jul 28, 2021
@droshev droshev added this to the Sprint 103 - Zurich milestone Dec 4, 2022
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 104, Sprint 105 Jan 25, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 105, Sprint 106 Feb 15, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 106, Sprint 107 Feb 24, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 107, Sprint 108 Mar 10, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 108, Sprint 109 Mar 20, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 109, Sprint 110 Mar 31, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 110, Sprint 111 Apr 14, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 111, Sprint 112 May 2, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 112, Sprint 113 May 15, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 113, Sprint 114 May 29, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 114, Sprint 115 Jun 9, 2023
@InnaAtanasova InnaAtanasova removed this from the Sprint 115 milestone Jun 26, 2023
@InnaAtanasova InnaAtanasova added this to the Sprint 116 milestone Jun 26, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 116, Sprint 117 Jul 7, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 117, Sprint 118 Jul 25, 2023
@droshev droshev modified the milestones: Sprint 118, Sprint 120 Aug 23, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 120, Sprint 121 Sep 5, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 123, Sprint 124 Oct 14, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 124, Sprint 125 Oct 27, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 125, Sprint 126 Nov 10, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 126, Sprint 127 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core library specific issues platform platform
Projects
None yet
Development

No branches or pull requests

2 participants