Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed List Item: Avatar shape #6204

Closed
daisy-yovcheva opened this issue Aug 3, 2021 · 3 comments
Closed

Feed List Item: Avatar shape #6204

daisy-yovcheva opened this issue Aug 3, 2021 · 3 comments
Assignees
Labels
design_team Issues raised by design team during acceptance testing design-discrepancy Fiori guidelines and Fiori visual specs not matching enhancement New feature or request platform platform
Milestone

Comments

@daisy-yovcheva
Copy link

Is this a bug, enhancement, or feature request?

Enhancement

Briefly describe your proposal.

Small change:
Recently, Fiori changed the shape of the avatar from rectangle to circle.

NGX:
Screen Shot 2021-08-02 at 6 43 58 PM

Fiori:
Ref link: https://ux.wdf.sap.corp/fiori-design-web/feedinput/
Screen Shot 2021-08-02 at 6 45 08 PM

@daisy-yovcheva daisy-yovcheva added enhancement New feature or request platform platform design_team Issues raised by design team during acceptance testing labels Aug 3, 2021
@puru-hk
Copy link
Contributor

puru-hk commented Aug 3, 2021

@daisy-yovcheva I check in fiori3 visual spec this is not an issues. As per the fiori3 visual spec we have implemented. Please find the below url fyi..
https://wiki.wdf.sap.corp/wiki/display/visualcore/Feed+%28Fiori+3%29+-+FeedListItem
https://wiki.wdf.sap.corp/wiki/display/visualcore/Feed+%28Fiori+3%29+-+FeedInput

@puru-hk puru-hk assigned daisy-yovcheva and unassigned puru-hk Aug 3, 2021
@puru-hk puru-hk added the design-discrepancy Fiori guidelines and Fiori visual specs not matching label Aug 3, 2021
@puru-hk
Copy link
Contributor

puru-hk commented Aug 3, 2021

we will wait for updated fiori3 visual spec. Therefore we mark it as design discrepancy.

@puru-hk puru-hk added not a bug Invalid/Not reproducible enhancement New feature or request and removed enhancement New feature or request not a bug Invalid/Not reproducible labels Aug 3, 2021
@kavya-b
Copy link
Contributor

kavya-b commented Sep 16, 2021

@daisy-yovcheva it is not quite clear from the visual spec when the avatar should have a circle shape and when it should have a rectangular shape.
avatar spec shows both variations:
image
and so does feed input spec:
image

are there specific rules on when an avatar should be a circle or a rectangle?

Please note we do have a property in ngx-avatar component called circle which when set gives the circular shape; you can see it here. However, currently there is no property available for the user to specify the shape of the avatar in platform feed input.

@daisy-yovcheva daisy-yovcheva changed the title Feed and Notes: Avatar shape Feed List Item: Avatar shape Nov 23, 2021
@droshev droshev added this to the Sprint 103 - Zurich milestone Dec 4, 2022
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 104, Sprint 105 Jan 25, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 105, Sprint 106 Feb 15, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 106, Sprint 107 Feb 24, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 107, Sprint 108 Mar 10, 2023
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 108, Sprint 109 Mar 20, 2023
@InnaAtanasova InnaAtanasova removed this from the Sprint 109 milestone Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design_team Issues raised by design team during acceptance testing design-discrepancy Fiori guidelines and Fiori visual specs not matching enhancement New feature or request platform platform
Projects
None yet
Development

No branches or pull requests

5 participants