-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile mode & fullscreen for menu and dialog #8634
Labels
Milestone
Comments
mikerodonnell89
added
bug
Something isn't working
enhancement
New feature or request
code refactoring
labels
Sep 1, 2022
5 tasks
InnaAtanasova
modified the milestones:
Sprint 99 - Guatemala,
Sprint 100 - San Salvador
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
According to the designs, any mobile menu should be a full-screen dialog. In some instances (see here) the dialog does not have a header. So this needs to be a configurable option of the mobile config.
Also the current implementation has a mobile dialog defaulting to this from
menu.component.ts
And in our documentation, the developer provides their own mobileConfig like so:
This does not preserve the default cancel button text, and it's unclear to the developer that they'll need to provide that property to keep the default. So I think there are two action items here:
dialogConfig: { mobile: true, fullScreen: true }
. i.e.MobileModeConfig
should not be an interface as we want to initialize some values for itAdditionally:
Affected components:
This is for any input that also displays a list of results
may be missing some
The text was updated successfully, but these errors were encountered: