Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile mode & fullscreen for menu and dialog #8634

Closed
9 tasks
mikerodonnell89 opened this issue Sep 1, 2022 · 0 comments
Closed
9 tasks

Mobile mode & fullscreen for menu and dialog #8634

mikerodonnell89 opened this issue Sep 1, 2022 · 0 comments
Labels
bug Something isn't working code refactoring enhancement New feature or request
Milestone

Comments

@mikerodonnell89
Copy link
Member

mikerodonnell89 commented Sep 1, 2022

According to the designs, any mobile menu should be a full-screen dialog. In some instances (see here) the dialog does not have a header. So this needs to be a configurable option of the mobile config.

Also the current implementation has a mobile dialog defaulting to this from menu.component.ts
Screen Shot 2022-09-01 at 3 19 56 PM

And in our documentation, the developer provides their own mobileConfig like so:
Screen Shot 2022-09-01 at 3 21 15 PM

This does not preserve the default cancel button text, and it's unclear to the developer that they'll need to provide that property to keep the default. So I think there are two action items here:

  • Mobile menu default config should contain dialogConfig: { mobile: true, fullScreen: true }. i.e.

Screen Shot 2022-09-01 at 3 22 28 PM

  • Mobile config example should show how to extend upon the existing default configuration rather than overwrite it. Or MobileModeConfig should not be an interface as we want to initialize some values for it

Additionally:

  • After opening the dialog, the initial focus should be set on the dialog and not in the input.
  • Input cursor should appear only after tapping in the input, and at that point the mobile keyboard should be displayed.

Affected components:
This is for any input that also displays a list of results

  • Combobox (core and platform)
  • Multi input (core and platform)
  • Multi combobox (platform)
  • Search field (platform)
  • Inputs in the shellbar

may be missing some

@mikerodonnell89 mikerodonnell89 added bug Something isn't working enhancement New feature or request code refactoring labels Sep 1, 2022
@mikerodonnell89 mikerodonnell89 added this to the Sprint 95 - Sao Paulo milestone Sep 1, 2022
@mikerodonnell89 mikerodonnell89 self-assigned this Sep 7, 2022
@InnaAtanasova InnaAtanasova modified the milestones: Sprint 104, Sprint 105 Jan 25, 2023
@mikerodonnell89 mikerodonnell89 removed their assignment Feb 10, 2023
@InnaAtanasova InnaAtanasova removed this from the Sprint 105 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code refactoring enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants