Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce output size #3393

Closed
g-cheishvili opened this issue May 9, 2022 · 2 comments
Closed

Reduce output size #3393

g-cheishvili opened this issue May 9, 2022 · 2 comments
Assignees
Labels
code refactoring Enhancement New feature or request
Milestone

Comments

@g-cheishvili
Copy link
Contributor

In fundamental styles, we no longer have support for IE11, so now we can get rid of the SASS variables and replace them with CSS variables it will reduce code size drammatically and increase readability. Context based variables would not have need to have additional selectors to change style of the elements. Modifiers can ONLY contain CSS variables.

Here is the example commit

@droshev
Copy link
Contributor

droshev commented Nov 25, 2022

@g-cheishvili

  • Can you list all the files where we should do that refactoring

@InnaAtanasova InnaAtanasova modified the milestones: Sprint 114, Sprint 115 Jun 9, 2023
@droshev
Copy link
Contributor

droshev commented Jun 21, 2023

We are doing that in steps while bringing Horizon design updates (#4403).

@droshev droshev closed this as completed Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code refactoring Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants