Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search suggestion list rendering broken starting with v0.39.0-rc.26 #4255

Closed
littleamigo opened this issue Feb 13, 2023 · 5 comments
Closed
Assignees
Milestone

Comments

@littleamigo
Copy link

In DXP we added suggestion to the search field recently and it worked very well for a few weeks with a fix provided with v0.39.0-rc.13. Since a few days we see a significant regression as the suggestion list is rendered far off the search control. I was able to nail it down to v0.39.0-rc.26 and discussed/pre-analyzed it shortly with @N1XUS. He asked me to open this ticket to follow up.

I tried but failed to provide a StackBlitz example because it uses v0.38.x and my attempt to upgrade to v0.39.x failed.

I just tried again with latest versions, same problem:
“@fundamental-ngx/core”: “0.39.0-rc.38",
“@fundamental-ngx/moment-adapter”: “0.39.0-rc.38",
“@fundamental-ngx/platform”: “0.39.0-rc.38",
“fundamental-styles”: “0.27.0-rc.8",

I appreciate your understanding that I cannot add a screenshot here as it would comprise too much SAP specific and personal data. Please contact @N1XUS and ask to share what he already got from me via Slack if you need it in case you cannot reproduce it on your own.

@droshev
Copy link
Contributor

droshev commented Jul 14, 2023

@IB002 Can you check whether the issue is still reprodicible?

@droshev droshev added this to the Sprint 117 milestone Jul 20, 2023
@IB002
Copy link
Contributor

IB002 commented Jul 20, 2023

Not reproducible in newer versions

Screenshots:

Screenshot 2023-07-20 at 10 23 54 AM

@IB002 IB002 closed this as completed Jul 20, 2023
@littleamigo
Copy link
Author

littleamigo commented Jul 20, 2023

Good to hear it's been resolved in newer versions. What are these newer versions? I need the exact minimum released version to adopt! @IB002

@IB002
Copy link
Contributor

IB002 commented Jul 21, 2023

The minimum release that you should adopt is v0.40.1.

@littleamigo
Copy link
Author

littleamigo commented Jul 28, 2023

I've tried with v0.41.0 and cannot confirm the fix. It looks still broken:
image

@IB002 Is there anything else that I need to update to adopt this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants