Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBI - Update/sync border color for input, combobox, dropdown with latest vscode variables #2471

Open
4 tasks
815are opened this issue Oct 17, 2024 · 2 comments
Open
4 tasks

Comments

@815are
Copy link
Contributor

815are commented Oct 17, 2024

Value

Styles should be up to date with VSCode themes

We noticed that standard buttons has border color --vscode-editorWidget-border while in latest VSCode theme there is variable --vscode-input-border.
We need to appy latest variable + additionally check also border for dropdowns/comboboxes, checkboxes if they aligned

Notes

Tasks

  • Input
  • Combobox
  • Dropdown
  • Checkbox
@gpeuc
Copy link
Contributor

gpeuc commented Oct 17, 2024

Checkboxes have their own set of variables.

Screenshot 2024-10-17 at 09 41 20

And we add focus-border as well to this mix.

@gpeuc
Copy link
Contributor

gpeuc commented Oct 17, 2024

Error states for inputs:

Screenshot 2024-10-17 at 09 43 34

normal: inputValidation-errorBorder

hover: charts-red

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants