generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all custom antialiasing [-webkit-font-smoothing] CSS lines #2474
Labels
ui-components
@sap-ux/ui-components
Comments
In conversation with mr. @815are this is what we will do:
This should then get rid of all forceful Font Smoothing, and leave it to the operating system to handle fonts. |
@815are Tried it and works for me as well. Let's create that initTheme in ui-components |
PR - #2478 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've just realised that we are rather randomly using
-webkit-font-smoothing: antialiased
through our CSS. Some elements will have that, some not. This on occasion causes issues when two things that are supposed to be the same actually render differently because one of them has forceful antialiasing, and another not.
The reality of this whole topic, on some higher level, is the following:
Webkit by default uses
-webkit-font-smoothing: subpixel-antialiased
which is a far superior method of antialiasing fonts as it does antialiasing on sub pixel level (so uses individual R / G / B diodes to do antialiasing, instead of entire pixel of the screen).Us overriding this causes problems.
It additionally causes problems because on Windows machines users can set how fonts render ("Smooth edges of screen fonts"), and sometimes this clashes with us then forcefully adding antialiasing.
Therefore, the best thing we could do is simply remove all
-webkit-font-smoothing: antialiased
that we have, and simply not mention it again. We let operating system, and user, choose how stuff renders. We should not interfere with that.https://usabilitypost.com/2012/11/05/stop-fixing-font-smoothing/
The text was updated successfully, but these errors were encountered: