Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - UI5linter sap ui5 bootstrap parameter changes not reflected in the preview sandbox.html template #2476

Open
1 of 3 tasks
heimwege opened this issue Oct 18, 2024 · 0 comments
Labels
preview-middleware @sap-ux/preview-middleware

Comments

@heimwege
Copy link
Contributor

Description

There seem to be some changes to the ui5 bootstrap parameters so the preview sandbox template needs to be adjusted.

  • data-sap-ui-compatVersion -> data-sap-ui-compat-version
  • data-sap-ui-resourceroots -> data-sap-ui-resource-roots
  • data-sap-ui-oninit -> data-sap-ui-oninit

sample from other project:
image

Not sure about the downward compatibility. But outdated notation might not be available in UI5 2.x

Steps to Reproduce

Steps to reproduce the behavior:

  1. eject html sandbox template to file system
  2. run ui5linter
  3. see findings

Expected results

No ui5Linter issues

Actual results

ui5Linter issues

Version/Components/Environment

Add any other context about the problem here
OS:

  • Mac OS
  • Windows
  • Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

@heimwege heimwege added the preview-middleware @sap-ux/preview-middleware label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview-middleware @sap-ux/preview-middleware
Projects
None yet
Development

No branches or pull requests

1 participant