Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - ACC TreeDropDown tab while dropdown is open does not set correct focus #2527

Open
1 of 3 tasks
ManuelPastorini opened this issue Nov 5, 2024 · 0 comments
Open
1 of 3 tasks

Comments

@ManuelPastorini
Copy link
Contributor

ManuelPastorini commented Nov 5, 2024

Description

When you select an entry in a TreeDropDown (with arrow keys), and then press tab to jump to the next input field without pressing space or enter for selecting first, the dropdown stays open and the focus is not set correctly.
If you press enter or space after choosing the right entry, the entry is selected, the dropdown is closed, and using tab afterwards navigates correctly.
In storybook, you can only partly reproduce: The dropdown stays open, but setting the next focus does not differ if using space/enter for selection in between or not, because there is no next input field.
For complete reproduction, you can use GD with any guide using a TreeDropDown, e.g. "Add a progress indicator column to a table" or "Add a rating indicator column to a table".

Steps to Reproduce

Steps to reproduce the behavior (with guide "Add a progress indicator column to a table"):

  1. Set up project according to packages/help/testcases/GuidesTestCases/CDSTestsPrerequisites.md
  2. Start guided development and choose guide "Add a progress indicator column to a table"
  3. Select CSD file "app\incidents\annotations.cds", Service "IncidentService", and Entity "Incidents"
  4. Navigate to field Navigation Path using keyboard navigation
  5. Use arrow-down to select priority. Don't use space or enter to select the entry
  6. Press tab to navigate to next field Property

Expected results

  1. Dropdown is closed
  2. Value for Navigation Path is priority
  3. Focus is on field Property

Actual results

  1. Dropdown is not closed
  2. Value seems not to be taken over (is still shown in the field, but when you click on the next field, it vanishes)
  3. Focus is somewhere else (in my case it's on the back button in VS Code header, but this seems not to be very reliable)

Version/Components/Environment

Add any other context about the problem here
OS:

  • Mac OS
  • Windows
  • Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant