Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBI - no middleware specific knowledge and type definitions in @sap-ux/ui5-config #2531

Open
2 tasks
heimwege opened this issue Nov 6, 2024 · 1 comment
Open
2 tasks
Labels
ui5-config @sap-ux/ui5-config

Comments

@heimwege
Copy link
Contributor

heimwege commented Nov 6, 2024

Description (include screenshots)

@sap-ux/ui5-config should provide a comfortable way to work with ui5.yaml files without having knowledge and type definition for all middlewares there. The type definition of a middleware belongs to the respective middleware. Module @sap-ux/ui5-config should be able to work with generics meaning, consumers bring their own type.

Value

Currently to support a new setting you need to update two modules. With this TBI changing or just adding a setting for a middleware no longer requires changing the type in @sap-ux/ui5-config.

Architecture Elaboration

Does it requires architecture elaboration? Yes

Notes

@Klaus-Keller @tobiasqueck

Tasks

  • Move existing middleware specific types from ui5-config to the respective middleware
  • Move existing middleware specific functions from ui5-config to the respective middleware
@heimwege heimwege added the ui5-config @sap-ux/ui5-config label Nov 6, 2024
@Klaus-Keller
Copy link
Contributor

Klaus-Keller commented Nov 6, 2024

Thanks @heimwege, this change makes sense to me and helps decoupling different modules and responsibilities. No objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui5-config @sap-ux/ui5-config
Projects
None yet
Development

No branches or pull requests

2 participants