Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add * to b2b forms required fields #19462

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

fix: add * to b2b forms required fields #19462

wants to merge 5 commits into from
+261 −88

Conversation

uroslates
Copy link
Contributor

Covered components:

  • Create Unit
  • Create User
  • Create Purchase Limit
  • Create Budget
  • Add New Request (Support Tickets)

Closes https://jira.tools.sap/browse/CXSPA-8763

@uroslates uroslates requested a review from a team as a code owner October 30, 2024 10:44
@github-actions github-actions bot marked this pull request as draft October 30, 2024 10:44
@uroslates uroslates marked this pull request as ready for review October 30, 2024 11:38
@cypress Cypress
Copy link

cypress bot commented Oct 30, 2024

spartacus    Run #45556

Run Properties:  status check passed Passed #45556  •  git commit 55be1616f0 ℹ️: Merge c3f3362a6bfe7b1d64f1dd1785bc410a39b495c1 into 7ab965a4ded64ae9a404da1f5187...
Project spartacus
Branch Review feature/CXSPA-8763
Run status status check passed Passed #45556
Run duration 11m 46s
Commit git commit 55be1616f0 ℹ️: Merge c3f3362a6bfe7b1d64f1dd1785bc410a39b495c1 into 7ab965a4ded64ae9a404da1f5187...
Committer Uros Lates
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Zeyber
Zeyber previously approved these changes Oct 30, 2024
View reviewed changes
@developpeurweb
Copy link
Contributor

@uroslates so far so good, let's go deeper...

  1. Please add this legend at the top of every form with required fields and asterisks. Please check current implementation in B2C.

required legend

  1. Let's please search for required fields across ALL the application code and implement the same thing, especially B2B (except ASM modules). It seems Validators.required is a search term that provides many results, please reach out to @Zeyber for suggestions on other search terms.

all required fields occurences

@github-actions github-actions bot marked this pull request as draft October 31, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeyber Zeyber Zeyber left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@uroslates @developpeurweb @Zeyber @ulates-sap