Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --browser cli argument for changing the default browser #712

Open
zdravko-georgiev opened this issue Dec 15, 2022 · 1 comment
Open
Labels
enhancement New feature or request module/ui5-cli Related to the UI5 CLI module

Comments

@zdravko-georgiev
Copy link

Is your feature request related to a problem? Please describe.

Using ui5 serve --open will open the server root directory in the default browser. But if you want to use a browser different than the default system browser, there is no way to specify it.

Describe the solution you'd like

The open package used by the ui5-tooling supports this feature. A simple solution could be adding an additional cli argument, e.g. --browser when one can specify the browser to be used, e.g. chrome|firefox|edge, the value can be then used when executing the open request.

Describe alternatives you've considered

Copying link and manually opening it in the desired browser

Additional context

Asked also by the community: https://answers.sap.com/questions/13751060/change-default-browser-used-by-vscodefiori-tools.html

@zdravko-georgiev zdravko-georgiev added the enhancement New feature or request label Dec 15, 2022
@RandomByte
Copy link
Member

Sounds like a good suggestion. The API is documented here: https://github.com/sindresorhus/open#usage

Maybe we should look into this together with: #623

@matz3 matz3 added the module/ui5-cli Related to the UI5 CLI module label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module/ui5-cli Related to the UI5 CLI module
Projects
None yet
Development

No branches or pull requests

3 participants