Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper generation fails if there is a duplicate component class in different webc package #147

Open
1 of 4 tasks
ilhan007 opened this issue Aug 27, 2024 · 0 comments
Open
1 of 4 tasks

Comments

@ilhan007
Copy link
Member

ilhan007 commented Aug 27, 2024

Bug Description

If there is a web component with the same name although in different package, as for example Button class in the ai library and Button in the "main" library, the wrapper generation fails.

Fails as in the generated index file two modules (from different locations) are exported under the same name "ButtonComponent".
export { ButtonComponent } from '@ui5/webcomponents-ngx/main/button';
export { ButtonComponent } from '@ui5/webcomponents-ngx/ai/button';

Until now the generation script did not expect name duplications of components (even though the components are in different packages/libraries) like the one described above.

Steps to Reproduce

  1. Setup the project to output wrappers for "ai" package (in addition to main and fiori)
  2. Run yarn build
  3. The output shows that there are two exports with the same name "ButtonComponent"
    export { ButtonComponent } from '@ui5/webcomponents-ngx/main/button';)
    export { ButtonComponent } from '@ui5/webcomponents-ngx/ai/button';

Context

  • UI5 Web Components version: latest
  • UI5 Web Components for Angular version: latest
  • Angular Version: {...}
  • OS/Platform: {...}
  • Browser: {...}
  • Affected component: ui5-ai-button

Log Output / Stack Trace / Screenshots

{...}

Priority

  • Low
  • Medium
  • High
  • Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

  • Breaks entire application or system - High or Very High
  • Accessibility issue - Medium or High
  • Functional issue - Medium or High
  • Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

  • Organization: {...}
  • Business impact: {...}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant