Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicated StemTag issue #31

Open
ValentineHerr opened this issue Apr 18, 2023 · 9 comments
Open

duplicated StemTag issue #31

ValentineHerr opened this issue Apr 18, 2023 · 9 comments
Assignees

Comments

@ValentineHerr
Copy link
Member

There are a number of (new?) stems that don't have a stemtag entered. And tag 10826 stemtag 2 has 3 different entries.

Hopefully you all are aware of this. I see in the comments that you have entered a tag number, so I am guessing the app was glitching for new stem tags?

Please see the error report if needed.

@CarolineTroy
Copy link
Collaborator

Hi Valentine - yes, the app currently won't let us edit the stem tag number when we add new stems. The field is automatically blank and uneditable. We are putting the stem tag number in the comments currently, but it is something we will need to resolve in the app. I'm not sure about the case for tag 10826 specifically, but we were occasionally also experiencing a glitch where when adding new stems to a new recruit, the stems weren't added to the recruit we were editing, but a separate recruit we had created earlier. In those cases we put the info for the new stems in the comments instead. Maybe that is why for 10826 there are 3 stem 2's.

@ValentineHerr
Copy link
Member Author

ok sounds good

@ValentineHerr
Copy link
Member Author

(@jess-shue, I am bringing the duplicated stemtag conversion in the corresponding issue.)

FYI, there are still 19 duplicated tag-stemtag duplicates, in 3 different quadrats. No indication of what the stemtag should be in the notes.

@jess-shue said that she is working on it.

@jess-shue
Copy link
Contributor

@ValentineHerr I've now added the correct StemTag number to those stems without a number.

I'm hesitant to change the duplicate numbers because of the colored wire. @mitreds, @rmh24, @CarolineTroy, @Iriskennedy, @krystalbagnaschi:
Any sense of stems of 10878, 10819, 10840, and 10826? You haven't been using tags but just wire, correct? I don't want to assign new numbers that wouldn't correspond to the wire color. Once you have tags, you can hopefully edit those stems in the app.

@ValentineHerr
Copy link
Member Author

ValentineHerr commented May 9, 2023

@jess-shue, Thanks for having delt with the problematic stems above.

However, now that I am bringing in recruit data, there is a systematic issue: the recruits stem table has the same data as the old_tree stem table (except the old stem has one extra column, dbh_2018_mm , but if I remove it, they are really identical, see code snippet below).
The tree tables are fine (old_tree one has a ton of rows, and recruits one only has a few hundreds).

Is this intended behavior? Shouldn't the recruits stem table only have the secondary stems associated with the recruits tree table?
Can you address that or should I find a way to address it in my code?

> old_stem <-  fread("raw_data/old_trees/stem_table_1.csv")
> recruits_stem <- fread("raw_data/recruits/stem_table_1.csv")
> old_stem$dbh_2018_mm <- NULL
> identical(recruits_stem, old_stem)
[1] TRUE

Note that once this is resolved, there will still be 26 duplicated stemtag issues to address.

ValentineHerr added a commit that referenced this issue May 9, 2023
@rmh24, @Iriskennedy, @CarolineTroy, @krystalbagnaschi
FYI, I redownloaded the data after you've fixed a lot of it.
- The duplicated stem issue will be dealt with separately. see issue #31
- There is still one unjustified dbh=0 that needs to be fixed, see issue #29
- For missed stem, I think we decided that you all will go through the ones that need to be changed to DN (when main stem is DN), the others are just waiting to be sampled (unfinished quadrat). Let me know if I am remembering that wrong.
- I'll address mortality census progress code (question of in progress vs completed, vs potentially new code and/or mortality map) in an new issue.
- There are still a few "CodeAButHOM1.3", I think some have notes that can help fixing the data. we may need to discuss this again.
@jess-shue
Copy link
Contributor

@ValentineHerr This is an artifact of how the 'view' is made - basically it is a copy of the tree and stem table. I did not include a column for stems that is in the tree table - thinking it would eliminate them as they are associated with the tree table but it did not.
I don't believe there is a good solution for this through ArcGIS Online - but let me look into it. I'm hesitant to do too much and mess things up!

@ValentineHerr
Copy link
Member Author

ok, keep me posted. And if it is too much to deal with it, just let me know and I'll come up with a plan on my end.

@ValentineHerr
Copy link
Member Author

Most of the duplicated tag issues were caused by the fact that the recruit stem table has the old tree stem table data in it.
I fixed that in the script.

So now, all the duplicated tags issues are legitimate and need to be addressed. @CarolineTroy @Iriskennedy @rmh24 @krystalbagnaschi let me know if we need to meet again about that and/or other data errors, or if you can address that alone.

@jess-shue
Copy link
Contributor

@ValentineHerr Thank you for scripting this, I didn't have a chance to work on it prior to my trip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants