-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duplicated StemTag issue #31
Comments
Hi Valentine - yes, the app currently won't let us edit the stem tag number when we add new stems. The field is automatically blank and uneditable. We are putting the stem tag number in the comments currently, but it is something we will need to resolve in the app. I'm not sure about the case for tag 10826 specifically, but we were occasionally also experiencing a glitch where when adding new stems to a new recruit, the stems weren't added to the recruit we were editing, but a separate recruit we had created earlier. In those cases we put the info for the new stems in the comments instead. Maybe that is why for 10826 there are 3 stem 2's. |
ok sounds good |
(@jess-shue, I am bringing the duplicated stemtag conversion in the corresponding issue.) FYI, there are still 19 duplicated tag-stemtag duplicates, in 3 different quadrats. No indication of what the stemtag should be in the notes. @jess-shue said that she is working on it. |
@ValentineHerr I've now added the correct I'm hesitant to change the duplicate numbers because of the colored wire. @mitreds, @rmh24, @CarolineTroy, @Iriskennedy, @krystalbagnaschi: |
@jess-shue, Thanks for having delt with the problematic stems above. However, now that I am bringing in recruit data, there is a systematic issue: the recruits stem table has the same data as the old_tree stem table (except the old stem has one extra column, Is this intended behavior? Shouldn't the recruits stem table only have the secondary stems associated with the recruits tree table? > old_stem <- fread("raw_data/old_trees/stem_table_1.csv")
> recruits_stem <- fread("raw_data/recruits/stem_table_1.csv")
> old_stem$dbh_2018_mm <- NULL
> identical(recruits_stem, old_stem)
[1] TRUE Note that once this is resolved, there will still be 26 duplicated stemtag issues to address. |
@rmh24, @Iriskennedy, @CarolineTroy, @krystalbagnaschi FYI, I redownloaded the data after you've fixed a lot of it. - The duplicated stem issue will be dealt with separately. see issue #31 - There is still one unjustified dbh=0 that needs to be fixed, see issue #29 - For missed stem, I think we decided that you all will go through the ones that need to be changed to DN (when main stem is DN), the others are just waiting to be sampled (unfinished quadrat). Let me know if I am remembering that wrong. - I'll address mortality census progress code (question of in progress vs completed, vs potentially new code and/or mortality map) in an new issue. - There are still a few "CodeAButHOM1.3", I think some have notes that can help fixing the data. we may need to discuss this again.
@ValentineHerr This is an artifact of how the 'view' is made - basically it is a copy of the tree and stem table. I did not include a column for stems that is in the tree table - thinking it would eliminate them as they are associated with the tree table but it did not. |
ok, keep me posted. And if it is too much to deal with it, just let me know and I'll come up with a plan on my end. |
Most of the duplicated tag issues were caused by the fact that the recruit stem table has the old tree stem table data in it. So now, all the duplicated tags issues are legitimate and need to be addressed. @CarolineTroy @Iriskennedy @rmh24 @krystalbagnaschi let me know if we need to meet again about that and/or other data errors, or if you can address that alone. |
@ValentineHerr Thank you for scripting this, I didn't have a chance to work on it prior to my trip! |
There are a number of (new?) stems that don't have a stemtag entered. And tag
10826
stemtag 2 has 3 different entries.Hopefully you all are aware of this. I see in the comments that you have entered a tag number, so I am guessing the app was glitching for new stem tags?
Please see the error report if needed.
The text was updated successfully, but these errors were encountered: