Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Improvements #263

Closed
6 of 7 tasks
evan-scales opened this issue Feb 6, 2024 · 3 comments
Closed
6 of 7 tasks

General Improvements #263

evan-scales opened this issue Feb 6, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@evan-scales
Copy link
Collaborator

evan-scales commented Feb 6, 2024

General improvements to be done. Some aiding with upcoming beta release, others just improvements

@evan-scales evan-scales self-assigned this Feb 6, 2024
@evan-scales evan-scales changed the title Use SearchService in api/users/connected/posts & api/relations/{userId}/{relationStatus} Use SearchService in social page related endpoints Feb 6, 2024
@jbytes1027
Copy link
Contributor

jbytes1027 commented Feb 6, 2024

Overall sound like a good plan. One thing I would change is to have the discovery user searches return friend status too for consistency and usability. Kinda like how when you search for a games on steam, it will mark the games you own in the results. Same for posts. Display the discover results the same as the social results.

Create new UserSearchOptions

Just add the options to PostQuery & UserQuery directly.

On the social page we should also allow the ability to sort users/posts based on activity of the chat

Good idea.

@evan-scales
Copy link
Collaborator Author

Just add the options to PostQuery & UserQuery directly

Okay

One thing I would change is to have the discovery user searches return friend status too

Yeah that would be a good idea too. I know we do that for posts already. I'll probably make a seperate issue for this

@evan-scales evan-scales changed the title Use SearchService in social page related endpoints General Improvements Feb 7, 2024
@evan-scales evan-scales removed their assignment Feb 7, 2024
@epadams epadams added the enhancement New feature or request label Feb 26, 2024
@jbytes1027
Copy link
Contributor

No longer see the point of this meta-issue and it's not being updated

@jbytes1027 jbytes1027 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants