Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

undefined index errors coming from xrouting #40

Open
nick2687 opened this issue Apr 22, 2021 · 6 comments
Open

undefined index errors coming from xrouting #40

nick2687 opened this issue Apr 22, 2021 · 6 comments

Comments

@nick2687
Copy link

I'm seeing these errors in my log anytime you navigate to or refresh any page on the site. I'm currently not using friendly urls - so i'm not sure if that is having an impact or what causes these to show up - any ideas on why php is throwing these warnings?


which seems to be coming from this line: 
$requestUrl = str_replace('//','/',$modx_base_url.$_REQUEST[$modx->getOption('request_param_alias', null, 'q')]);

[2021-04-21 23:39:41] (WARN @ /paas/c1038/www/core/cache/includes/elements/modplugin/41.include.cache.php : 146) PHP notice: Undefined index: xrouting-debug

which seems to be coming from this line: 
 if ($_REQUEST['xrouting-debug'] == '1' && $modx->getOption('xrouting.allow_debug_info', null, false)) {

@Mark-H
Copy link

Mark-H commented Jan 31, 2023

Can confirm these errors are still getting logged, however they have been upgraded to a PHP warning (which translates to an ERROR level in the MODX log) on PHP8.

@Quentin100
Copy link

Getting the same on PHP 8, although it doesn't affect the system, just clogs up my log file:

modplugin/26.include.cache.php : 146) PHP warning: Undefined array key "xrouting-debug"
modplugin/26.include.cache.php : 100) PHP warning: Undefined array key "q"

@Jako
Copy link
Contributor

Jako commented Feb 15, 2023

There is a completely refactored version 1.5.0 available at my GitHub fork. Sadly Christian did not answer yet on my mail how to publish that version.

@Mark-H
Copy link

Mark-H commented Feb 15, 2023

Probably start with a pull request so they can review and merge it?

@Jako
Copy link
Contributor

Jako commented Feb 15, 2023

You see the age of #36?

@dev-willis
Copy link

Getting the same on PHP 8, although it doesn't affect the system, just clogs up my log file:

modplugin/26.include.cache.php : 146) PHP warning: Undefined array key "xrouting-debug" modplugin/26.include.cache.php : 100) PHP warning: Undefined array key "q"

same

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants