-
Notifications
You must be signed in to change notification settings - Fork 0
/
ChangeLog
1351 lines (950 loc) · 45.8 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2008-07-17 Olav Vitters <[email protected]>
* mango/urls.py: Allow more characters in a module name.
2008-07-13 Olav Vitters <[email protected]>
* mango/views.py (setup_filter): Allow filter to be emptied whenever
it was specified within the GET request. Not entirely sure this works
as is needed.
2008-07-13 Olav Vitters <[email protected]>
* mango/views.py (edit_module): Add l10n details to XML.
2008-07-12 Olav Vitters <[email protected]>
* www/update_module.xsl: Correct links to various views.
2008-07-12 Olav Vitters <[email protected]>
* mango/models.py (qobject_inlist): New function to create an 'inlist'
Q object.
* mango/urls.py: Add edit_module view to URL.
* mango.views,py (edit_module): New view. Allows an existing module to
be edited. Currently doesn't allow any update to be done.
* www/list_modules.xsl: Correct link to the edit_module view.
2008-06-28 Olav Vitters <[email protected]>
* mango/views.py (setup_filter, list_users, list_accounts,
list_mirrors, list_foundationmembers, list_modules): Remember the
used filters within the session data.
2008-06-28 Olav Vitters <[email protected]>
* www/login.xsl: Correct various links.
* www/page.xsl:
2008-06-28 Olav Vitters <[email protected]>
* lib/mysql.php: Request results as UTF8.
2008-06-28 Olav Vitters <[email protected]>
* mango/models.py (Foundationmembers.need_to_renew): Don't fail when
last_renewed_on is false (new foundation members).
* mango/urls.py: Add URL for new add_foundationmember view.
* mango/views.py (add_foundationmember): Allow creation of new
foundation members.
* www/list_foundationmembers.xsl: Correct link to add_foundationmember
view.
* www/new_foundationmember.xsl: Correct link to view.
2008-06-28 Olav Vitters <[email protected]>
* mango/models.py (Foundationmembers): Set initial last_renewed_on to
current date.
2008-06-28 Olav Vitters <[email protected]>
* mango/models.py (Foundationmembers, FoundationmembersForm,
FoundationmembersForm.clean): Allow foundation membership to be
renewed.
2008-06-27 Olav Vitters <[email protected]>
* www/list_accounts.xsl: Add status column. Also, submit the search
form whenever there status dropdown changes.
2008-06-27 Olav Vitters <[email protected]>
* mango/views.py (list_accounts): Allow filtering of accounts on
status and on cn/name/uid.
* www/list_accounts.xsl: Make sure the chosen status is selected
again.
2008-06-27 Olav Vitters <[email protected]>
* mango/models.py (LdapObject._build_filter): Add hackish way to
specify a __contains LDAP query.
* mango/views.py (list_users): Allow filtering on uid, cn, mail.
2008-06-27 Olav Vitters <[email protected]>
* mango/views.py (setup_filter, list_mirrors, list_foundationmembers,
list_modules): Introduce a setup_filter function and use it
whenever possible.
* www/list_foundationmembers.xsl:
2008-06-27 Olav Vitters <[email protected]>
* mango/views.py (list_foundationmembers): Allow filtering on
foundation members (firstname, lastname, email and status).
* www/list_foundationmembers.xsl: Adjust per above.
2008-06-27 Olav Vitters <[email protected]>
* mango/views.py (list_modules): Allow modules result page to be
filtered.
2008-06-27 Olav Vitters <[email protected]>
* mango/views.py (add_mirror): Ensure active column is set to 1 when a
new mirror is added.
2008-06-27 Olav Vitters <[email protected]>
* mango/models.py (Users.modules): Add modules property to User model.
2008-06-27 Olav Vitters <[email protected]>
-- WARNING THIS IS INSECURE --
Add 'logging in' to Mango. Notice: Doesn't check password or anything.
Only ensures the userid is known.
* mango/urls.py: Add handle_login and handle_logout views.
* mango/views.py (get_xmldoc, handle_login, handle_logout): In
get_xmldoc, add for the current logged in user to the HTML instead of
hardcoding me. In handle_login, don't pretend to be secure and just
log in the user.
* www/index.xsl: Ensure URLs to the views are correct.
* www/page.xsl: Correct URLs to login/logout pages.
2008-06-25 Olav Vitters <[email protected]>
* mango/views.py (get_xmldoc, setup_xml_paginator, list_users,
edit_user, list_mirrors, add_foundationmember_to_xml,
list_foundationmembers): Don't create intermediate node variable
when it isn't needed.
2008-06-25 Olav Vitters <[email protected]>
* mango/views.py (edit_foundationmember): Also update for the
get_xmldoc changes.
2008-06-25 Olav Vitters <[email protected]>
* mango/views.py:Remove even more dead code.
2008-06-25 Olav Vitters <[email protected]>
* mango/views.py: Remove some dead code.
2008-06-24 Olav Vitters <[email protected]>
* mango/views.py (setup_xml_paginator, list_users, list_accounts,
list_mirrors, list_foundationmembers, list_modules): Expand
add_paginator_to_xml functionality and rename the function to
setup_xml_paginator. It now also creates the paginator and gets the
selected objects. Change existing usage of this function to match
new functionality (meaning: remove duplicate lines).
2008-06-24 Olav Vitters <[email protected]>
* mango/views.py (list_users): Limit the number of attributes that are
requested. Additionally, change the XML we pass on to the template.
The new XML uses the same node name as the name of the LDAP attribute.
* www/list_users.xsl: Look for the new element names.
2008-06-24 Olav Vitters <[email protected]>
* mango/views.py (get_xmldoc): Make it actually work.
2008-06-24 Olav Vitters <[email protected]>
* mango/views.py (get_xmldoc, list_users, edit_user, view_index,
list_accounts, add_account, list_mirrors, edit_mirror, add_mirror,
list_foundationmembers, edit_foundationmember, list_modules): Adding
a subpagenode is so common, add the functionality to get_xmldoc.
2008-06-24 Olav Vitters <[email protected]>
* mango/views.py (edit_user, add_account, list_mirrors, edit_mirror,
add_mirror): Name the variables more consistently.
2008-06-24 Olav Vitters <[email protected]>
* mango/models.py (Foundationmembers, FoundationmembersForm,): Require
certain Foundationmembers model fields to be filled in. Correct the
name of the FoundationmembersForm.
* mango/urls.py: Add URL for the edit_foundationmember view.
* mango/views.py (add_foundationmember_to_xml, list_foundationmembers,
edit_foundationmember, list_modules): Create new function
add_foundationmember_to_xml. This either uses the form information
or the form instance to add the member to the XML. Create a new view
called edit_foundationmember, allowing a foundationmember record to
be updated.
* www/list_foundationmembers.xsl: Correct links to the
edit_foundationmember view.
* www/update_foundationmember.xsl: Correct link to
edit_foundationmember view.
2008-06-24 Olav Vitters <[email protected]>
* mango/models.py (Foundationmembers): Add is_member and need_to_renew
properties.
* mango/views.py (list_foundationmembers): Add missing information to
the XML.
2008-06-24 Olav Vitters <[email protected]>
* mango/views.py (list_accounts): Add paginator to account request
overview. Further, only show pending setup accounts. Currently not
possible to change that.
2008-06-23 Olav Vitters <[email protected]>
* mango/models.py (Users.add_to_xml, Modules, Modules.maintainer,
Modules.add_to_xml, L10nModules): Fix Users.add_to_xml to actually
work. For Modules, maintainerUid is a MULTI_ATTR, not memberUid.
Further, add a maintainer property (joins maintainerUid together).
Finally, add an add_to_xml helper function.
* mango/urls.py: Add list_modules view to configuration. Also change
the way existing views are referenced.
* mango/views.py (list_modules): New view. Shows modules.
* www/list_modules.xsl: Update scriptname so that links point to the
right place.
2008-06-23 Olav Vitters <[email protected]>
* INSTALL: Add some short incomplete notes about the Python (Django)
port.
2008-06-23 Olav Vitters <[email protected]>
* mango/models.py (LdapObject.search, Users.groups): Remove leftover
debug message. Further, optimize use of LDAP queries by only
requesting the cn of groups within the Users class.
2008-06-23 Olav Vitters <[email protected]>
* mango/views.py (list_users): Add pagination to list_users. This is
way more inefficient than normal models as LdapObject actually creates
an instance for every user, no matter if it is needed by the paginator
or not.
* www/list_users.xsl: Correct link to list_users view.
2008-06-23 Olav Vitters <[email protected]>
* mango/views.py (list_mirrors): Show mirrors per page (25).
* www/list_ftpmirrors.xsl: Correct link to list_mirrors view.
2008-06-23 Olav Vitters <[email protected]>
Even more fixes due to introduction of Q.
* mango/models.py (Modules, L10nModules):
* mango/views.py (list_users):
2008-06-23 Olav Vitters <[email protected]>
* mango/views.py (add_account): Fix title used in document.
2008-06-23 Olav Vitters <[email protected]>
Fix regressions due to instruction of new method to search LDAP (SVN
revision 237).
* mango/models.py (UserGroups, Users.groups): Add default filter to
UserGroups. Update groups function to ensure the filter uses a Q
object.
* mango/views.py (get_xmldoc, edit_user): Use Q when providing a
filter for LDAP.
2008-06-23 Olav Vitters <[email protected]>
* mango/models.py (AccountsForm: Add new Form, derived from the
AccountRequest model.
2008-06-23 Olav Vitters <[email protected]>
* HACKING: Update HACKING with current design thoughts and a TODO
list (incomplete).
2008-06-23 Olav Vitters <[email protected]>
* mango/models.py (LdapObject, LdapObject.search, LdapObject.method,
LdapObject._build_filter, Users, Modules, L10nModules, DevModules):
Add a _build_filter function to LdapObject. This converts a query
filter made up by 'Q' to an ldap filter. It also handles quoting,
AND, OR and NOT. Change the LdapObject search function to make use
of _build_filter.
Further, allow an LdapObject derived class to have a predefined
filter. This filter will be AND'ed together with any filters
provides to the LdapObject search function.
Set default FILTER for Users class. Further, create two new classes
derived from Module class; L10nModules and DevModules. Each of these
classes has a filter which only returns a certain module.
* mango/views.py (add_account): Instead of providing a filter to the
Modules class, use the newly created L10nModules and DevModules
classes.
2008-06-23 Olav Vitters <[email protected]>
* mango/models.py (Ftpmirrors.ault): Make mirror active by default.
* mango/urls.py: Make add_mirror view available as
/foundationmembers/add/.
* mango/views.py (add_mirror): New function. Add a new mirror. Upon
saving it will redirect so the mirror can be updated.
* www/new_ftpmirror.xsl: Update URL to reflect Django changes.
2008-06-23 Olav Vitters <[email protected]>
* mango/views.py (add_form_errors_to_xml, edit_mirror): Add new
function which checks if the form is valid. If not, it adds the errors
to the XML. Needs to be renamed to better clarify what it does. In
edit_mirror, make use of this helper function.
* www/list_ftpmirrors.xsl: Update link to new ftp mirror to follow
Django style.
2008-06-22 Olav Vitters <[email protected]>
* mango/models.py (Foundationmembers, Ftpmirrors): Ensure first_added
will have the current date. Update the Ftpmirrors to use more specific
model fields (allowing Django to verify it).
2008-06-22 Olav Vitters <[email protected]>
* mango/models.py (Modules): Add Modules class, reflecting the modules
in LDAP.
* mango/urls.py: Make add_account view available as /requests/add/
* mango/views.py (add_account): Do the bare minimum to have the XSLT
template display the form. Submitting doesn't work at this stage.
2008-06-22 Olav Vitters <[email protected]>
* mango/urls.py: Enable fake view_index (doesn't do anything).
* mango/views.py (view_index): Rename test_index to view_index
2008-06-22 Olav Vitters <[email protected]>
* mango/models.py (Foundationmembers.Meta): Order the foundation
members by lastname, then firstname. This like the PHP version.
2008-06-22 Olav Vitters <[email protected]>
* mango/views.py (edit_mirror, list_foundationmembers): Make use of
get_object_or_404. Also give 404 error message when invalid page was
given.
* www/list_foundationmembers.xsl: Make script variable '.'. This as
Django appears as directories.
2008-06-22 Olav Vitters <[email protected]>
* mango/views.py (add_paginator_to_xml, list_accounts,
list_foundationmembers): Paginate results from a query. Add
paginated entries to the XML by use of the add_paginator_to_xml
function.
* www/list_foundationmembers.xsl: Correct links for paginator.
2008-06-22 Olav Vitters <[email protected]>
* mango/models.py (AccountGroups): Ensure Account uid only consists of
lowercase letters.
2008-06-22 Olav Vitters <[email protected]>
* mango/models.py (Foundationmembers, FtpmirrorsForm,
FtpmirrorsForm.Meta, Users.groups, Users.add_to_xml): Correct the
Foundationmembers model. Add a FoundationmembersForm. Lastly, add a
add_to_xml function to the Users model.
* mango/urls.py: Change accounts URL to requests. Also add the
list_foundationmembers view.
* mango/views.py (list_foundationmembers): Show foundation member
details. Far from fully working.
2008-06-22 Olav Vitters <[email protected]>
* mango/settings.py: Remove 'www' from hard coded URL.
* mango/views.py (get_xmlresponse): Add 'www' to template location.
* www/page.xsl: Add 'www' for the CSS. Update tab URLs to match Django
install.
2008-06-22 Olav Vitters <[email protected]>
* mango/views.py (get_xmldoc): Hard code the logged in user to me for
now.
2008-06-22 Olav Vitters <[email protected]>
* mango/models.py (Ftpmirrors): Active is a BooleanField.
2008-06-22 Olav Vitters <[email protected]>
* mango/models.py (AccountRequest, AccountRequest.ault,
AccountRequest.ault, AccountRequest.ault, AccountGroups.ault,
Ftpmirrors, Ftpmirrors.Meta, Ftpmirrors.add_to_xml, FtpmirrorsForm,
FtpmirrorsForm.Meta, Webmirrors): Prevent some fields in various
models from being editable. Further, add an FtpmirrorsForm, based
upon Ftpmirrors model. Lastly, add an add_to_xml helper function to
the Ftpmirrors model.
* mango/urls.py: Add new edit ftpmirror view.
* mango/views.py (list_mirrors, edit_mirror): Create new view which
allows an ftpmirror to be updated. Make list_mirrors view use
add_to_xml helper function.
* www/list_ftpmirrors.xsl: Update the link used to edit an ftpmirror.
* www/update_ftpmirror.xsl: Add link back to list_mirrors view. Also
make sure the POST goes to the right place.
2008-06-22 Olav Vitters <[email protected]>
* mango/urls.py: Add list_mirrors view.
* mango/views.py (list_mirrors): Fetch ftp mirrors from database,
optionally filtering it by a keyword.
2008-06-22 Olav Vitters <[email protected]>
* lib/ftpmirror.php (FTPMirror): variables / attributes / whatever
should be public, not private.
2008-06-22 Olav Vitters <[email protected]>
* www/list_users.xsl: Update links to Django clean urls.
* www/update_user.xsl: Update links to Django clean urls.
2008-06-22 Olav Vitters <[email protected]>
* mango/settings.py (ault): Hard code the base_url for now.
* mango/views.py (get_xmlresponse, list_users, edit_user, test_index,
list_accounts): Make get_xmlresponse use base_url to provide a
reference to the XSLT template. Change existing usage of this
function to match changed functionality.
2008-06-22 Olav Vitters <[email protected]>
* mango/views.py (edit_user): Make use of Users ldap helper class.
Further, add group information to XML.
2008-06-22 Olav Vitters <[email protected]>
* mango/models.py (UserGroups, Users, Users.__init__, Users.groups):
Add UserGroups, representing an LDAP group. Make use of this group as
a lazily initialized property within the Users group.
2008-06-22 Olav Vitters <[email protected]>
* mango/views.py (list_users): Make use of new Users class.
2008-06-22 Olav Vitters <[email protected]>
* mango/models.py (LdapObject): New class that can search for
something in LDAP. Is not very smart atm.
(Users): Uses LdapObject to store a user in.
2008-06-22 Olav Vitters <[email protected]>
* mango/urls.py: Add new view 'edit_user'.
* mango/views.py (edit_user): Add new view. Get uid information from
ldap and give it to the template. Doesn't show everything in the
template and also fails to do actually do anything.
2008-06-22 Olav Vitters <[email protected]>
* mango/views.py (list_users): Return XML instead of debug text.
For now, just add all LDAP users in the XML.
2008-06-21 Olav Vitters <[email protected]>
* mango/models.py: Add LdapUtil singleton. Maintains a single
connection to the LDAP database.
* mango/views.py: Make use of the LDAP singleton.
2008-06-21 Olav Vitters <[email protected]>
* mango/__init__.py: Add this file as well (moap didn't notice it).
2008-06-21 Olav Vitters <[email protected]>
Try and port the mess to Python using the Django framework.
* .bzrignore: Ignore the django directory.
* mango/manage.py: Standard Django script to manage the Django
project.
* mango/models.py: Describes the Database (needs a bit of work).
* mango/settings.py: Django settings and the config.xml file.
* mango/urls.py: Maps URLs to functions which will be called.
* mango/views.py: Handles turning an http request into an http
response (application/xml).
2008-06-08 Olav Vitters <[email protected]>
* lib/util.php: Correctly throw the Exception.
2008-06-03 Olav Vitters <[email protected]>
* www/update_module.xsl: Don't allow the module name to be edited.
LDAP doesn't support it.
2008-06-03 Olav Vitters <[email protected]>
* www/update_module.xsl: Sort maintainers on full name and show
userid.
2008-06-03 Olav Vitters <[email protected]>
* www/update_module.xsl: Add link back to list_modules.php.
2008-06-03 Olav Vitters <[email protected]>
* www/index.xsl: Add a focus function to the onload handler. The
inline javascript executes way too early to do anything.
* www/login.xsl: Add a focus function to the onload handler. The
inline javascript executes way too early to do anything.
2008-06-03 Olav Vitters <[email protected]>
* lib/module.php: Only provide current maintainers to the xml. Showing
all users is not useful. Further, validate the given userids (should
be done in a better way, but good enough for now).
* www/update_module.xsl: Show checkboxes for the existing users and an
input box to enter a new maintainer userid. Would be nice to be able
to search for someones userid, but this is good enough.
2008-06-02 Olav Vitters <[email protected]>
* www/update_user.php: Determine if an error message was shown last
time. If so, the saving should be tried again; even if no change was
made in the form.
2008-06-02 Olav Vitters <[email protected]>
* lib/ber.php: Add BER decoder. Mango doesn't need it, but I thought
it would, so let's just add it anyway.
2008-06-02 Olav Vitters <[email protected]>
* lib/util.php: Parse the SSH public key data to determine the real
bit length. Change the is_valid_ssh_pub_key function to give more
feedback (array instead of just 'false').
* lib/account.php: Adapt to is_valid_ssh_pub_key return changes.
* lib/user.php: Adapt to is_valid_ssh_pub_key return changes.
2008-06-02 Olav Vitters <[email protected]>
* templates/maintainer_approval.xsl: Add not about passwords.
2008-06-01 Olav Vitters <[email protected]>
Try to avoid unknown people from requesting an account by hiding the
new account link. Also ensure the examples refer to RSA, not DSA.
* www/index.xsl:
* www/login.xsl:
* www/new_account.xsl:
* www/new_user.xsl:
* www/update_user.xsl:
2008-06-01 Olav Vitters <[email protected]>
Fix loads of E_STRICT errors and convert a few things to PHP5 style
classes.
* lib/account.php:
* lib/authtoken.php:
* lib/foundationmember.php:
* lib/ftpmirror.php:
* lib/ldap.php:
* lib/module.php:
* lib/page.php:
* lib/user.php:
* www/common.php:
* www/index.php:
* www/list_accounts.php:
* www/list_foundationmembers.php:
* www/list_ftpmirrors.php:
* www/list_modules.php:
* www/list_users.php:
* www/login.php:
* www/new_account.php:
* www/new_foundationmember.php:
* www/new_ftpmirror.php:
* www/new_module.php:
* www/new_user.php:
* www/update_foundationmember.php:
* www/update_ftpmirror.php:
* www/update_module.php:
* www/update_user.php:
2008-06-01 Olav Vitters <[email protected]>
Add configuration options for mail backend. Patch by Patrick Fey
with slight modifications by me.
* INSTALL: Document the new configuration options.
* config.xml-gnome: Add new configuration options to example file.
* lib/config.php: Add new config option. Olav: rewrite it to avoid
repeating the same code plus convert to PHP5 class.
* lib/util.php: Add send_mail function. Olav: slightly modified to
avoid repeating the same code and only to set the mail params which
have been set in the config.
* lib/user.php: Make use of send_mail function.
* www/list_foundationmembers.php: Make use of send_mail function.
* www/new_foundationmember.php: Make use of send_mail function.
* www/update_foundationmember.php: Make use of send_mail function.
* lib/account.php: Pass account_email config option to the templates.
Make use of send_mail function.
* templates/authtoken_mail_verification.xsl: Use account_email.
* templates/inform_accounts.xsl: Use account_email.
* templates/maintainer_approval.xsl: Use account_email.
* templates/requestor_status_change.xsl: Use account_email.
2008-06-01 Olav Vitters <[email protected]>
* lib/page.php: Convert to PHP5 style object.
2008-06-01 Olav Vitters <[email protected]>
* lib/mysql.php: Avoid notice when password is empty.
* lib/user.php:
* www/update_user.php: Complain loudly if user wasn't updated due to
validation errors.
2008-06-01 Olav Vitters <[email protected]>
* lib/util.php: Add array_same helper function.
* www/update_user.php: Fix logic once again (PHP is weird). Further,
check if the user was changed before attempting an update.
2008-06-01 Olav Vitters <[email protected]>
* www/update_user.xsl: Ignore individual key additions and removals.
* lib/user.php: Add _update_sshkey function and use it for SSH key
removals and additions.
2008-06-01 Olav Vitters <[email protected]>
* lib/user.php: Always check key length.
* www/update_user.xsl: Show SSH key errors.
2008-06-01 Olav Vitters <[email protected]>
* www/update_user.php: Ensure all attributes of a user are updated;
meaning: if there are changes in the general section, the SSH keys
should still receive updates as well.
2008-06-01 Olav Vitters <[email protected]>
* www/update_user.xsl: Make SSH keys clickable.
2008-06-01 Olav Vitters <[email protected]>
* www/update_user.php: Kill the tabs. They just make updating a user
more annoying as not everything is on one page, plus you cannot switch
between 'tabs' without saving the user.
* www/update_user.xsl: Kill tabs in the UI as well.
2008-05-31 Olav Vitters <[email protected]>
* www/update_user.php: PHP5 style object.
2008-05-31 Olav Vitters <[email protected]>
* lib/user.php: Typo fix.
* www/update_user.php: Remove savedkey handling. Just pass the entire
key to the form, much easier.
* www/update_user.xsl: Follow changes made above.
2008-05-31 Olav Vitters <[email protected]>
* lib/user.php: Rework shell granting.
2008-05-31 Olav Vitters <[email protected]>
* lib/user.php: Change to PHP5 style object.
2008-05-31 Olav Vitters <[email protected]>
* lib/user.php: Rework the which_shell and which_homedir functions.
They're still a bit stupid, but at least it is consistently stupid.
* www/index.php: Set page title to 'Main page' when user is logged in.
* www/page.xsl: Update copyright year.
2008-05-30 Olav Vitters <[email protected]>
* docs/schemas/gnome.schema: Combination of below files, makes server
configuration easier.
* docs/schemas/cvs.schema:
* docs/schemas/module.schema:
* docs/schemas/sshd.schema:
2008-05-23 Olav Vitters <[email protected]>
* templates/maintainer_approval.xsl: Fix typo. Patch by Patrick Fey.
2008-05-23 Olav Vitters <[email protected]>
Allow membership committee to specify the GNOME userid for each
foundation member.
* docs/sql/foundationmembers.sql:
* lib/foundationmember.php:
* www/new_foundationmember.php:
* www/new_foundationmember.xsl:
* www/update_foundationmember.php:
* www/update_foundationmember.xsl:
2008-05-22 Olav Vitters <[email protected]>
* www/update_user.php: Allow changing of membership committee.
* www/update_user.xsl: Make it valid XSLT.
2008-05-22 Olav Vitters <[email protected]>
* www/update_user.xsl: Link back to the list_users.php and show the
userid being edited.
2008-05-22 Olav Vitters <[email protected]>
* www/update_user.xsl: Group the groups. Meaning: developer related
groups together, foundation stuff together, etc.
2008-05-22 Olav Vitters <[email protected]>
* lib/user.php: Only remove pubkeyAuthenticationUser if user currently
has that object.
2008-05-22 Olav Vitters <[email protected]>
* templates/user_instructions.xsl: Fix Danglish.
2008-05-22 Olav Vitters <[email protected]>
* www/update_user.php: Add foundation membership group.
* www/update_user.xsl:
2008-05-20 Olav Vitters <[email protected]>
* templates/user_instructions.xsl: Whenever an SSH key is added,
inform the user about *all* the SSH keys currently set on the account.
Could be better, but oh well.
2008-05-20 Olav Vitters <[email protected]>
* lib/user.php: Typo fix.
* www/update_user.php: Allow the inform_user function to be ran.
2008-05-20 Olav Vitters <[email protected]>
* lib/user.php:
* templates/user_instructions.xsl: Inform the user regarding SSH key
changes. Initial version.. untested.
2008-05-20 Olav Vitters <[email protected]>
* lib/user.php:
* templates/user_instructions.xsl:
* www/new_user.php:
* www/update_user.xsl: Prepare work to inform the user regarding key
changes.
2008-05-17 Olav Vitters <[email protected]>
* lib/user.php: When adding new SSH keys: Only add
pubkeyAuthenticationUser objectclass if that objectclass is missing
instead of assuming it isn't there if there aren't any SSH keys.
Allows adding of SSH keys for people who had their SSH key removed due
to Debian/Ubuntu SSH security issue.
2008-03-04 Olav Vitters <[email protected]>
* lib/user.php: Don't validate uid again for users existing in LDAP.
2007-12-08 Olav Vitters <[email protected]>
patch by: Patrick Fey
* www/new_account.php: Catch ldap authentication error in
new_account.php.
2007-12-08 Olav Vitters <[email protected]>
patch by: Patrick Fey
* lib/module.php: Eliminate useless generic ldap authentication error
messages.
2007-12-08 Olav Vitters <[email protected]>
reviewed by: <delete if not using a buddy>
patch by: <delete if not someone else's patch>
* www/new_account.php:
2007-12-08 Olav Vitters <[email protected]>
patch by: Patrick Fey
* lib/ldap.php: Return error messages raised during connection to LDAP
server. This was broken due to the switch to the singleton method.
2007-12-08 Olav Vitters <[email protected]>
patch by: Patrick Fey
* lib/ldap.php: Use ldap url instead of hostname to connect to ldap
server.
2007-12-08 Olav Vitters <[email protected]>
patch by: Patrick Fey
* docs/ldif/ou.ldif: Make docs/ou.ldif work out of the box
2007-12-08 Olav Vitters <[email protected]>
patch by: Patrick Fey
* INSTALL: Improve installation instructions.
2007-12-04 Olav Vitters <[email protected]>
* config.xml-gnome: Make it valid XML.
2007-11-27 Olav Vitters <[email protected]>
* www/index.xsl: Stupid IE6 cannot approve SVN accounts due to missing
action="$URL".
2007-11-17 Olav Vitters <[email protected]>
* www/index.php: Show userid as well to allow maintainers to reject
invalid userids.
* www/index.xsl:
2007-11-11 Olav Vitters <[email protected]>
* lib/account.php: Allow to select accounts in a status other than
'S'. Filtering doesn't work yet.
* www/list_accounts.php: Allow to reject accounts.
* www/list_accounts.xsl:
2007-10-27 Olav Vitters <[email protected]>
* www/verify_mail.xsl: Set libgo.channel.
2007-10-23 Olav Vitters <[email protected]>
* www/page.xsl: Don't define libgo.channel twice.
2007-10-23 Olav Vitters <[email protected]>
* www/index.xsl: Use correct attribute for the email address.
2007-10-20 Olav Vitters <[email protected]>
* lib/account.php: Ensure multiple maintainers will be emailed.
* lib/module.php:
2007-10-03 Olav Vitters <[email protected]>
* templates/inform_accounts.xsl: Email address is now in <mail>; not
in <email>.
2007-10-01 Olav Vitters <[email protected]>
* lib/account.php: Don't allow usernames to consist of just one of the
given names (first/last name).
* www/list_foundationmembers.php: Only look at $_REQUEST['page'] if it is a number.
* www/list_users.php: Only look at $_REQUEST['page'] if it is a number.
2007-09-29 Olav Vitters <[email protected]>
* templates/inform_accounts.xsl: Ehr, forgot to add to the repos.
2007-09-28 Olav Vitters <[email protected]>
* www/new_account.xsl: Sort the modules by name.
2007-09-28 Olav Vitters <[email protected]>
* www/common.php: Don't cache any session data.
* www/update_user.php: It is sendRedirect, not redirect.
2007-09-27 Olav Vitters <[email protected]>
Fix wording so it look more like English.
* lib/page.php:
* templates/authtoken_mail_verification.xsl:
* templates/maintainer_approval.xsl:
* templates/requestor_status_change.xsl:
* www/login.xsl:
* www/new_account.xsl:
* www/verify_mail.xsl:
2007-09-27 Olav Vitters <[email protected]>
Be more paranoid.
* lib/user.php: Check for valid user.
* www/common.php: Change session settings to be more secure.
* www/login.php: Avoid session fixation attacks by use of
session_regenerate_id.
* www/new_user.php: Use update_status instead of obsolete
update_verdict.
2007-09-26 Olav Vitters <[email protected]>
Rewrite how the accounts are handled.
* docs/sql/mango.sql:
* lib/account.php:
* lib/module.php:
* lib/user.php:
* templates/maintainer_approval.xsl:
* www/index.php:
* www/index.xsl:
* www/list_accounts.php:
* www/list_accounts.xsl:
* www/new_account.php:
* www/new_account.xsl:
* www/verify_mail.php:
* www/verify_mail.xsl:
2007-09-24 Olav Vitters <[email protected]>
* lib/user.php: Don't check the key length. Too many existing users
have too short keys for this to work.
2007-09-24 Olav Vitters <[email protected]>
* www/update_user.php: Always run validate before updating the user.
Further, avoid copy/paste code.
2007-09-23 Olav Vitters <[email protected]>
* lib/account.php: Fix error in the email code. Every maintainer would
always get an email, even if the request wasn't for them.
2007-09-23 Olav Vitters <[email protected]>
* lib/util.php: Older ssh-keygens allowed DSA keys other than 1024
bits. Allow everything with 1024 or more bits. Not sure if they'll
allow a login though.
2007-09-23 Olav Vitters <[email protected]>
Fix loads of errors by RATS and an evaluation version of Zend Studio.
Unless specified otherwise, the fixes are for unused variables.
* lib/account.php: Also don't use "" to surround regexps (should be
''). Fix how _send_email is called.
* lib/config.php:
* lib/module.php:
* lib/mysql.php:
* lib/page.php:
* lib/user.php: Also don't use "" to surround regexps (should be '').
* www/list_accounts.php:
* www/login.php:
* www/new_account.php:
* www/new_foundationmember.php:
* www/new_ftpmirror.php:
* www/new_module.php:
* www/new_user.php:
* www/update_foundationmember.php: Also use correct idcheck variable.
* www/update_ftpmirror.php:
* www/update_module.php:
* www/update_user.php:
2007-09-23 Olav Vitters <[email protected]>
* lib/user.php: Typo, causing emails not to go to the user.
2007-09-22 Olav Vitters <[email protected]>
* lib/account.php: Update column names to match schema.
2007-09-22 Olav Vitters <[email protected]>
* lib/foundationmember.php: Enable renew button as from 1 month before
expiration.
2007-09-22 Olav Vitters <[email protected]>
* docs/ldif/ou.ldif: Add required groups to the example LDIF file.
Without these groups Mango will not function correctly.
2007-09-21 Olav Vitters <[email protected]>
* lib/account.php: Validate SSH keys
* www/new_account.php: Clear the stored SSH keys every time the form
is read. Otherwise it isn't possible to not add certain SSH keys.
Although this should at one point just use checkboxes.
* www/new_account.xsl: Mention that requesters should read
lgo/NewAccounts first.
2007-09-21 Olav Vitters <[email protected]>
* lib/account.php: Load account data when the email address has been
verified. This allows the maintainer approval email to contain
information regarding the account request.
Additionally, use better subjects for various emails.
* lib/user.php: Use better subjects in the emails going to the GNOME
account owner.
* templates/maintainer_approval.xsl: Warn maintainers that they are