Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI parameters for window settings #1546

Closed
3 tasks
heinezen opened this issue Sep 17, 2023 · 4 comments · Fixed by #1726
Closed
3 tasks

CLI parameters for window settings #1546

heinezen opened this issue Sep 17, 2023 · 4 comments · Fixed by #1726
Labels
area: renderer Concerns our graphics renderer good first issue Suitable for newcomers lang: c++ Done in C++ code lang: cython Implemented using Cython code lang: python Done in Python code nice new thing ☺ A new feature that was not there before

Comments

@heinezen
Copy link
Member

Required Skills: Python, some C++

Difficulty: Easy

Several window parameters could be set via the CLI on startup. Examples for these parameters include:

  • window size (height x width)
  • vsync
  • fullscreen/borderless/windowed

Most of the parameters are already supported by the renderer::Window class. All we have to do is pass them through from the Python CLI.

Tasks:

  • Start parameters have to be defined in Python for start modes main and game
  • Pass parameters to C++ invocation main_arguments struct
  • in C++, pass relevant parameters to presenter/renderer subsystem

Further Reading
@heinezen heinezen added area: renderer Concerns our graphics renderer nice new thing ☺ A new feature that was not there before lang: c++ Done in C++ code lang: python Done in Python code lang: cython Implemented using Cython code labels Sep 17, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in openage renderer Sep 17, 2023
@heinezen heinezen added the good first issue Suitable for newcomers label Sep 17, 2023
@heinezen heinezen moved this from 📋 Backlog to 🔖 TODO in openage renderer Sep 17, 2023
@heinezen heinezen moved this to renderer in openage beginner tasks Sep 17, 2023
@heinezen heinezen pinned this issue Sep 17, 2023
@heinezen heinezen added the hacktoberfest For newcomers from Hacktoberfest event label Sep 27, 2023
@stoyanov-kaloyan

This comment was marked as outdated.

Sign in to view
@heinezen

This comment was marked as outdated.

Sign in to view
@Aayush-lad Aayush-lad mentioned this issue Oct 3, 2023
Closed
@heinezen heinezen removed the hacktoberfest For newcomers from Hacktoberfest event label Nov 4, 2023
@jTorresR8 jTorresR8 mentioned this issue Feb 12, 2024
Closed
@RaulGalvez288

This comment was marked as outdated.

Sign in to view
@TheJJ

This comment was marked as outdated.

Sign in to view
@RaulGalvez288 RaulGalvez288 mentioned this issue Aug 20, 2024
Closed
@ZzzhHe ZzzhHe mentioned this issue Dec 4, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🔖 TODO to ✅ Done in openage renderer Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: renderer Concerns our graphics renderer good first issue Suitable for newcomers lang: c++ Done in C++ code lang: cython Implemented using Cython code lang: python Done in Python code nice new thing ☺ A new feature that was not there before
Projects
openage beginner tasks
Archived in project
openage renderer
Status: ✅ Done
Milestone
No milestone
4 participants
@TheJJ @heinezen @stoyanov-kaloyan @RaulGalvez288