Bind empty VAO to bufferless quad rendering #1734
Open
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 👋 resolve #1659
I've made some initial fixes for the bufferless quad VAO issue, but wanted to get some advice before finalizing:
I tested my current code and noticed the VAO error was still there but occurred during shader validation in
GlShaderProgram::use().This happens during
program->update_uniforms(in);beforegeom->draw(); inGlRenderer::render().My current fix is binding the empty VAO in
geometry.cpp, but I'm wondering:GlShaderProgram::use()?appreciate your thoughts on the best approach!