-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of socket disconnection and failure to establish connection #122
Comments
IMO this is desired behavior. You can use the published diagnostics for monitoring the health of the driver. |
@reinzor, Maybe I was not able to describe the problem correctly. |
Hi thanks for raising, |
Hi We can fix this by simply changing the For the second part of the problem where if we are using only UDP connection for data and no more TCP request after initialization we can put a watchdog monitoring on received packets on UDP handler, then If for a configurable amount of time no UDP packet has been received we change the node state to reconnection and publish reconnection state to a topic or existing driver health, where we try a TCP request with multiple or infinite retries, once we get a response after the Lidar is connected back, we re-establish the UDP connection part to start receiving the UDP data again. This will allow the node to self recover own its own instead of shutting down and restarting again. Please feel free for the feedback in above approach so that I can start working on it. |
PR submitted : #131 |
Thanks for submitting the PR. I will check it and if everything seems to be working will merge it into the driver |
Hi,
The package does not support the socket connection failures, it simply just logs it and silently do nothing about it. It would be nice to have
The text was updated successfully, but these errors were encountered: