Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ingest_spectral_types function #481

Closed
kelle opened this issue Mar 8, 2024 · 1 comment · Fixed by #539
Closed

Refactor ingest_spectral_types function #481

kelle opened this issue Mar 8, 2024 · 1 comment · Fixed by #539
Assignees

Comments

@kelle
Copy link
Collaborator

kelle commented Mar 8, 2024

Should be just for one spectral type, not for a list of them.

Change:

n_added = 0
n_skipped = 0

to a flags dictionary with added and skipped keys.

flags = {'added': 0, 'skipped': 0}
if <added>:
    flags['added'] = 1
if <skipped>:
     flags['skipped]=1
...
return flags
@kelle
Copy link
Collaborator Author

kelle commented Jul 12, 2024

We want to get this done so Austin can use it in #482 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants