Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't the halos be circular, not elliptical? #6

Open
unfa opened this issue Nov 8, 2021 · 1 comment
Open

Shouldn't the halos be circular, not elliptical? #6

unfa opened this issue Nov 8, 2021 · 1 comment

Comments

@unfa
Copy link

unfa commented Nov 8, 2021

Hey! This is amazing, and I'd love to understand better how it works!

That being said - shouldn't the halos be following a circle rather than an ellipse?
Unless the camera is using an anamorphic lens, the optic elements are all circular, so the effect should not be squeezed to display aspect ratio, it should be cropped on the top and bottom.

Could there be a control added to change that?

I guess anamorphic lens flares are a different beast alltogether :)

@SIsilicon
Copy link
Owner

SIsilicon commented Nov 8, 2021

You are correct that the halo should be circular. In fact, the shader has a uniform called stretch_to_aspect to control this. It's been a while since I used it, so try playing with the value to see what it does.
The uniform is right here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants