Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a url.txt file without the related jar? #322

Closed
WorkInProgress-Development opened this issue Aug 18, 2019 · 4 comments
Closed

Use a url.txt file without the related jar? #322

WorkInProgress-Development opened this issue Aug 18, 2019 · 4 comments
Labels
enhancement

Comments

@WorkInProgress-Development
Copy link

Is there any workaround to allow putting only a link to the mod download and not having to mirror a copy onto our own server?

Sorry if this is completely unclear.
@spannerman79
Copy link

There is a PR that should cover that for you

@WorkInProgress-Development
Copy link
Author

I assume you mean this one: #273
It's a little unclear how I should use it in practice. Do I need to edit the source code file at launcher-builder/src/main/java/com/skcraft/launcher/builder/ClientFileCollector.java, or just used the linked creator-tools-2.0.2-SNAPSHOT-all.jar.zip file?

Again, apologies if I'm missing something obvious.

@spannerman79
Copy link

Do I need to edit the source code

Yes.

@hedgehog1029 hedgehog1029 linked a pull request Dec 24, 2020 that will close this issue
RFC: Allow .url.txt files only inside src/mods/ #273
Closed
2 tasks
@hedgehog1029
Copy link
Member

Implemented by 67f3fc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RFC: Allow .url.txt files only inside src/mods/ jkroepke/Launcher
3 participants
@hedgehog1029 @spannerman79 @WorkInProgress-Development