Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on WORKS/_FORM #53

Open
grammaton opened this issue May 17, 2016 · 6 comments
Open

on WORKS/_FORM #53

grammaton opened this issue May 17, 2016 · 6 comments
Assignees
Milestone

Comments

@grammaton
Copy link
Contributor

  <div class="actions">
    <%= f.submit 'Select author(s)' %>
  </div>
@grammaton
Copy link
Contributor Author

The Submit Changes button has bad name

@grammaton
Copy link
Contributor Author

@nicb I need Your Help!
the code:

    <% unless @work.new_record? %>
      <div class="authors">
         <%= f.label 'Associated authors' %><br />

         <table class="table" id="authors">
           <thead>
             <th>Name</th>
             <th>Year</th>
             <th>Roles</th>
             <th></th>
             <th></th>
             <th></th>
           </thead>
           <tbody>
             <%= render partial: 'authors/author_item', collection: @work.authors.uniq %>
           </tbody>
         </table>

      </div>
      <div class="add_new_author">
        <%= link_to 'Add new author', new_work_author_path(@work), class:"btn" %>
      </div>
    <% end %>

  <div class="actions">
    <%= f.submit 'Select author(s)', class:"btn" %>
  </div>
<% end %>

That code produce both Add new Author and Select author(s) buttons while editing works.

@grammaton
Copy link
Contributor Author

grammaton commented May 17, 2016

@nicb I'm working on gs-cap branch

@grammaton
Copy link
Contributor Author

@nicb the problem is that in EDIT mode of the form the Select author(s) button must be Save Changes

@nicb
Copy link
Contributor

nicb commented May 28, 2016

Sorry @grammaton I don't get the issue. What is the problem in having the capability of editing/adding authors while editing a Work?

@grammaton
Copy link
Contributor Author

The is not the capability of editing but the Select Authors´ button name in case of simple editing. An example: The user made mistakes on Biography or on other text field. He pusheditand fix text. At the end of fixture He expect a button namedSave ChangesnotSelect Authors`. I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants