Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ambiguity of offset precision of Date.date #29

Open
eldesh opened this issue Jun 15, 2020 · 0 comments
Open

ambiguity of offset precision of Date.date #29

eldesh opened this issue Jun 15, 2020 · 0 comments

Comments

@eldesh
Copy link

eldesh commented Jun 15, 2020

Basis Date sais:

Offsets are taken modulo 24 hours. That is, we express t, in hours, as sgn(t)(24*d + r), where d and r are non-negative, d is integral, and r < 24.

r < 24 means that r is in hours.
And by we express t, in hours, r should be integral.

But in general, the Time.time for offset has a finer precision than seconds.

And SML/NJ 110.97 keep values finer that hour like below:

- Date.toString (Date.date { year=2000, day= 1, hour=0, minute=0, month=Date.Jan, offset=SOME (Time.fromSeconds (0)), second=0});
val it = "Sat Jan 01 00:00:00 2000" : string
- Date.toString (Date.date { year=2000, day= 1, hour=0, minute=0, month=Date.Jan, offset=SOME (Time.fromSeconds (1)), second=0});
val it = "Sat Jan 01 00:00:01 2000" : string (* +1 sec *)

I think the specification should be modified to keep seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant