Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi player showcase #3

Closed
amtins opened this issue Jan 29, 2024 · 0 comments · Fixed by #10
Closed

Add multi player showcase #3

amtins opened this issue Jan 29, 2024 · 0 comments · Fixed by #10
Assignees
@jboix
Labels
enhancement New feature or request

Comments

@amtins
Copy link
Member

amtins commented Jan 29, 2024 •
edited
Loading

As a developer, I want to have an example showing multiple player instances on the same page.

Acceptance Criteria

  • An example is available on the showcase section
  • The user can pick which instance is active at any time
  • The active instance is the only one that is not muted
  • The active instance is the only one to send the analytics (see property trackersDisabled)

Limitation
@jboix jboix transferred this issue from SRGSSR/pillarbox-web Jan 30, 2024
@jboix jboix added the enhancement New feature or request label Feb 5, 2024
@jboix jboix self-assigned this Feb 13, 2024
@jboix jboix moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Feb 13, 2024
jboix added a commit that referenced this issue Feb 16, 2024
@jboix
feat(showcase): add multi-player showcase
34edc09 
Resolves #3 by introducing a new showcase that displays multiple players on the same page. A button
has been added to allow the user to toggle the mute state for both players.

Note: only one player can have active tracking at a time, an issue has been created to provide
documentation for this limitation, see: SRGSSR/pillarbox-web#208.
@jboix jboix mentioned this issue Feb 16, 2024
Merged
jboix added a commit that referenced this issue Feb 16, 2024
@jboix
feat(showcase): add multi-player showcase
f4ce253 
Resolves #3 by introducing a new showcase that displays multiple players on the same page. A button
has been added to allow the user to toggle the mute state for both players.

Note: only one player can have active tracking at a time, an issue has been created to provide
documentation for this limitation, see: SRGSSR/pillarbox-web#208.
@jboix jboix moved this from 🚧 In Progress to 🍿 Code Review in Pillarbox Feb 16, 2024
jboix added a commit that referenced this issue Feb 16, 2024
@jboix
feat(showcase): add multi-player showcase
88073fe 
Resolves #3 by introducing a new showcase that displays multiple players on the same page. A button
has been added to allow the user to toggle the mute state for both players.

Note: only one player can have active tracking at a time, an issue has been created to provide
documentation for this limitation, see: SRGSSR/pillarbox-web#208.
jboix added a commit that referenced this issue Feb 16, 2024
@jboix
feat(showcase): add multi-player showcase
0d465cb 
Resolves #3 by introducing a new showcase that displays multiple players on the same page. A button
has been added to allow the user to toggle the mute state for both players.

Note: only one player can have active tracking at a time, an issue has been created to provide
documentation for this limitation, see: SRGSSR/pillarbox-web#208.
github-merge-queue bot pushed a commit that referenced this issue Feb 16, 2024
@jboix
feat(showcase): add multi-player showcase
85bc5c1 
Resolves #3 by introducing a new showcase that displays multiple players on the same page. A button
has been added to allow the user to toggle the mute state for both players.

Note: only one player can have active tracking at a time, an issue has been created to provide
documentation for this limitation, see: SRGSSR/pillarbox-web#208.
@jboix jboix closed this as completed in #10 Feb 16, 2024
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jboix jboix

Labels
enhancement New feature or request
Projects
Pillarbox
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(showcase): add multi-player showcase SRGSSR/pillarbox-web-demo
2 participants
@jboix @amtins