Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume playback of a briefly seen segment might resume before its start #90

Open
defagos opened this issue Sep 28, 2018 · 3 comments
Open
Labels
bug Issue to be fix (issue and PR) - release notes section

Comments

@defagos
Copy link
Member

defagos commented Sep 28, 2018

If a segment as been very briefly played, resuming it will efficiently try to seek at the nearest chunk before the position. Currently the start position can be located before the segment. It should not.

Issue type

Incorrect behavior

Environment information

  • Application version: 2.8.5
  • iOS version: Any
  • Device: Any

Reproducibility

Always reproducible

Steps to reproduce

  1. Open a segment (e.g. 19h30 subject).
  2. Immediately close it.
  3. Reopen it. If the segment start was not in the direct vicinity of a chunk start, playback will resume before the segment. Otherwise pick another segment.
@defagos
Copy link
Member Author

defagos commented Oct 1, 2018

This is an SRG Media Player issue. I opened a dedicated ticket on its issue tracker.

@defagos
Copy link
Member Author

defagos commented Oct 3, 2018

For the moment, as this is an AVPlayer bug, we decided to put this issue on hold. We could use accurate seeking when resuming playback, but we decided that for the moment this was acceptable as it is now.

I'll update this issue once I have more feedback from Apple.

@defagos defagos transferred this issue from another repository Mar 25, 2019
@defagos defagos added maintenance Code maintenance (issue and PR) - release notes section bug Issue to be fix (issue and PR) - release notes section labels Mar 25, 2019
@defagos
Copy link
Member Author

defagos commented Oct 11, 2021

This issue has been fixed by Apple. We don't use tolerances at the moment because of an issue with RTS content (SRGSSR/srgletterbox-apple#245). We must ensure this issue is fixed as well before we re-enable tolerances again (tolerance before only for resuming playback efficiently). We might also prefer to use precise seeking for resuming playback, in which case this issue can be closed.

@pyby pyby removed the maintenance Code maintenance (issue and PR) - release notes section label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue to be fix (issue and PR) - release notes section
Projects
None yet
Development

No branches or pull requests

2 participants