diff --git a/Cartfile b/Cartfile index ae6c1713..f8c2566b 100644 --- a/Cartfile +++ b/Cartfile @@ -1,5 +1,5 @@ github "SRGSSR/ComScore-iOS-watchOS-tvOS" "5.8.4" -github "SRGSSR/srgdataprovider-ios" "6.7" -github "SRGSSR/srgidentity-ios" "1.0.3" -github "SRGSSR/srgmediaplayer-ios" "2.7.1" +github "SRGSSR/srgdataprovider-ios" "6.8" +github "SRGSSR/srgidentity-ios" "1.0.4" +github "SRGSSR/srgmediaplayer-ios" "2.8" github "SRGSSR/tagcommander-ios" "4.3.3_4.3.1" diff --git a/Cartfile.private.common b/Cartfile.private.common index 05f96132..648ce048 100644 --- a/Cartfile.private.common +++ b/Cartfile.private.common @@ -1,3 +1,2 @@ -github "kif-framework/KIF" == 3.6.0 -# Fork from AliSoftware/OHHTTPStubs to support Xcode 9.x and Swift 4. -github "rckoenes/OHHTTPStubs" ~> 6.1.1 \ No newline at end of file +github "kif-framework/KIF" ~> 3.7.8 +github "AliSoftware/OHHTTPStubs" ~> 8.0.0 \ No newline at end of file diff --git a/Cartfile.resolved.proprietary b/Cartfile.resolved.proprietary index c7b2e6dd..bac1996e 100644 --- a/Cartfile.resolved.proprietary +++ b/Cartfile.resolved.proprietary @@ -1,3 +1,4 @@ +github "AliSoftware/OHHTTPStubs" "8.0.0" github "Mantle/Mantle" "2.1.0" github "SRGSSR/ComScore-iOS-watchOS-tvOS" "5.8.4" github "SRGSSR/FXReachability" "1.3.2_srg3" @@ -6,12 +7,11 @@ github "SRGSSR/Masonry" "v1.1.0_srg1" github "SRGSSR/UICKeyChainStore" "v2.1.2_srg1" github "SRGSSR/libextobjc" "0.6_srg1" github "SRGSSR/srgcontentprotection-ios" "1.2.3" -github "SRGSSR/srgdataprovider-ios" "6.7" +github "SRGSSR/srgdataprovider-ios" "6.8" github "SRGSSR/srgdiagnostics-ios" "1.0.1" -github "SRGSSR/srgidentity-ios" "1.0.3" +github "SRGSSR/srgidentity-ios" "1.0.4" github "SRGSSR/srglogger-ios" "1.1" -github "SRGSSR/srgmediaplayer-ios" "2.7.1" +github "SRGSSR/srgmediaplayer-ios" "2.8" github "SRGSSR/srgnetwork-ios" "1.0.3" github "SRGSSR/tagcommander-ios" "4.3.3_4.3.1" -github "kif-framework/KIF" "v3.6.0" -github "rckoenes/OHHTTPStubs" "6.1.1" +github "kif-framework/KIF" "v3.7.8" diff --git a/Cartfile.resolved.public b/Cartfile.resolved.public index 24d76f15..ad1e8422 100644 --- a/Cartfile.resolved.public +++ b/Cartfile.resolved.public @@ -1,3 +1,4 @@ +github "AliSoftware/OHHTTPStubs" "8.0.0" github "Mantle/Mantle" "2.1.0" github "SRGSSR/ComScore-iOS-watchOS-tvOS" "5.8.4" github "SRGSSR/FXReachability" "1.3.2_srg3" @@ -6,12 +7,11 @@ github "SRGSSR/Masonry" "v1.1.0_srg1" github "SRGSSR/UICKeyChainStore" "v2.1.2_srg1" github "SRGSSR/libextobjc" "0.6_srg1" github "SRGSSR/srgcontentprotection-fake-ios" "1.2.3" -github "SRGSSR/srgdataprovider-ios" "6.7" +github "SRGSSR/srgdataprovider-ios" "6.8" github "SRGSSR/srgdiagnostics-ios" "1.0.1" -github "SRGSSR/srgidentity-ios" "1.0.3" +github "SRGSSR/srgidentity-ios" "1.0.4" github "SRGSSR/srglogger-ios" "1.1" -github "SRGSSR/srgmediaplayer-ios" "2.7.1" +github "SRGSSR/srgmediaplayer-ios" "2.8" github "SRGSSR/srgnetwork-ios" "1.0.3" github "SRGSSR/tagcommander-ios" "4.3.3_4.3.1" -github "kif-framework/KIF" "v3.6.0" -github "rckoenes/OHHTTPStubs" "6.1.1" +github "kif-framework/KIF" "v3.7.8" diff --git a/Demo/Info.plist b/Demo/Info.plist index d68ce8de..5bf01890 100644 --- a/Demo/Info.plist +++ b/Demo/Info.plist @@ -10,6 +10,8 @@ $(PRODUCT_BUNDLE_IDENTIFIER) CFBundleInfoDictionaryVersion 6.0 + CFBundleDisplayName + Analytics CFBundleName $(PRODUCT_NAME) CFBundlePackageType diff --git a/Demo/Sources/Demos/DemosViewController.m b/Demo/Sources/Demos/DemosViewController.m index f131ece9..66e9051c 100644 --- a/Demo/Sources/Demos/DemosViewController.m +++ b/Demo/Sources/Demos/DemosViewController.m @@ -147,6 +147,7 @@ - (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath labels.comScoreCustomInfo = @{ @"media_id" : @(indexPath.row).stringValue }; SRGMediaPlayerViewController *playerViewController = [[SRGMediaPlayerViewController alloc] init]; + playerViewController.modalPresentationStyle = UIModalPresentationFullScreen; [playerViewController.controller playURL:URL atPosition:nil withSegments:nil analyticsLabels:labels userInfo:nil]; [self presentViewController:playerViewController animated:YES completion:nil]; break; diff --git a/Demo/Sources/Demos/DemosViewController.storyboard b/Demo/Sources/Demos/DemosViewController.storyboard index 862b0b4e..785225ca 100644 --- a/Demo/Sources/Demos/DemosViewController.storyboard +++ b/Demo/Sources/Demos/DemosViewController.storyboard @@ -1,11 +1,11 @@ - + - + @@ -24,14 +24,14 @@ - + @@ -41,14 +41,14 @@ - + @@ -58,14 +58,14 @@ - + @@ -75,14 +75,14 @@ - + @@ -92,14 +92,14 @@ - + @@ -109,14 +109,14 @@ - + @@ -134,10 +134,10 @@ @@ -151,10 +151,10 @@ @@ -168,10 +168,10 @@ @@ -189,10 +189,10 @@ diff --git a/Demo/Sources/Simple/SimpleViewController.storyboard b/Demo/Sources/Simple/SimpleViewController.storyboard index a86e458c..45d82988 100644 --- a/Demo/Sources/Simple/SimpleViewController.storyboard +++ b/Demo/Sources/Simple/SimpleViewController.storyboard @@ -1,11 +1,9 @@ - - - - + + - + @@ -19,21 +17,21 @@ - + diff --git a/Makefile b/Makefile index 14ddefed..e7dad198 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,8 @@ #!/usr/bin/xcrun make -f +# Xcode 11 workaround, see https://github.com/Carthage/Carthage/issues/2825#issuecomment-513160923 +export XCODE_XCCONFIG_FILE=../../../xcode11fix.xcconfig + CARTHAGE_FOLDER=Carthage CARTHAGE_RESOLUTION_FLAGS=--new-resolver --no-build CARTHAGE_BUILD_FLAGS=--platform iOS --cache-builds diff --git a/SRGAnalytics.xcodeproj/project.pbxproj b/SRGAnalytics.xcodeproj/project.pbxproj index ec162a4c..4368ecb2 100644 --- a/SRGAnalytics.xcodeproj/project.pbxproj +++ b/SRGAnalytics.xcodeproj/project.pbxproj @@ -1797,7 +1797,7 @@ GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; IPHONEOS_DEPLOYMENT_TARGET = 9.0; - MARKETING_VERSION = 3.7.3; + MARKETING_VERSION = 3.7.4; ONLY_ACTIVE_ARCH = YES; SDKROOT = iphoneos; TARGETED_DEVICE_FAMILY = "1,2"; @@ -1994,7 +1994,7 @@ GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; IPHONEOS_DEPLOYMENT_TARGET = 9.0; - MARKETING_VERSION = 3.7.3; + MARKETING_VERSION = 3.7.4; SDKROOT = iphoneos; TARGETED_DEVICE_FAMILY = "1,2"; VALIDATE_PRODUCT = YES; @@ -2336,7 +2336,7 @@ GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; IPHONEOS_DEPLOYMENT_TARGET = 9.0; - MARKETING_VERSION = 3.7.3; + MARKETING_VERSION = 3.7.4; ONLY_ACTIVE_ARCH = YES; SDKROOT = iphoneos; TARGETED_DEVICE_FAMILY = "1,2"; @@ -2389,7 +2389,7 @@ GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; IPHONEOS_DEPLOYMENT_TARGET = 9.0; - MARKETING_VERSION = 3.7.3; + MARKETING_VERSION = 3.7.4; SDKROOT = iphoneos; TARGETED_DEVICE_FAMILY = "1,2"; VALIDATE_PRODUCT = YES; diff --git a/xcode11fix.xcconfig b/xcode11fix.xcconfig new file mode 100644 index 00000000..a9f9f15f --- /dev/null +++ b/xcode11fix.xcconfig @@ -0,0 +1,2 @@ +LD_VERIFY_BITCODE__XCODE_PRODUCT_BUILD_VERSION_11M374r=NO +LD_VERIFY_BITCODE=$(LD_VERIFY_BITCODE__XCODE_PRODUCT_BUILD_VERSION_$(XCODE_PRODUCT_BUILD_VERSION))