Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make analyze more flexible #239

Open
pabloferz opened this issue Dec 16, 2022 · 3 comments
Open

Make analyze more flexible #239

pabloferz opened this issue Dec 16, 2022 · 3 comments
Labels

Comments

@pabloferz
Copy link
Member

pabloferz commented Dec 16, 2022

We should give the user the ability to switch free energy integration routines. We can provide this as an argument to analyze.

CC @ricalessandri

@ricalessandri
Copy link
Member

As part of this, we should take care of fixing something in the functions that generate the free energy of FUNN and ABF. In fact, they show some systematic error (left), that gets fixed if the forces are integrated using this py script from the SSAGES repo (right):

Screen Shot 2023-01-10 at 3 34 18 PM

Screen Shot 2023-01-10 at 3 38 40 PM

@ricalessandri
Copy link
Member

This is how the integration error seem to look in 1D CV case (butane w/ HOOMD-blue and FUNN):
Screen Shot 2023-01-10 at 3 42 27 PM

@pabloferz
Copy link
Member Author

#249 should help at least with the errors you are seeing here. The more flexible interface for analyze still needs some tinkering.

@pabloferz pabloferz added the API label Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants