New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is charSetSize field ever used? #3

Open

alexeyr opened this issue Jul 6, 2021 · 1 comment

alexeyr commented Jul 6, 2021

CocoR-CPP/src/Scanner.frame

Line 245 in b7e87c5

int charSetSize;

is a field which doesn't seem to be used in generated code. Can it be safely removed?

mingodad commented Jul 6, 2021

Good catch looking through several CocoR variants I have only one for FSharp uses something like :

https://github.com/blucz/coco-r-fsharp/blob/4b7e07df08f795a23e5f1015455e5c95b51b93a7/ScannerOutput.cs#L329
https://github.com/blucz/coco-r-fsharp/blob/4b7e07df08f795a23e5f1015455e5c95b51b93a7/Tab.cs#L195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment