Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 The ADR template should use the standard for replaceable text placeholders #189

Open
1 task
GordonBeeming opened this issue Oct 27, 2023 · 3 comments
Open
1 task
Labels
Type: Bug A problem with existing functionality

Comments

@GordonBeeming
Copy link
Member

GordonBeeming commented Oct 27, 2023

Cc: @jernejk

Hi

Describe the Bug

As per Do you use the right character for replaceable text placeholders?, we should update the placeholders in the ADR template to use {{ PLACEHOLDER }}

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://github.com/SSWConsulting/SSW.CleanArchitecture/blob/main/docs/adr/template.md?plain=1
  2. Observe the placeholders use [ placeholders ]

Expected Behavior

Placeholders should be in the format {{ PLACEHOLDER }}

Tasks

  • Update placeholders

Thanks!

@GordonBeeming GordonBeeming added the Type: Bug A problem with existing functionality label Oct 27, 2023
@GordonBeeming
Copy link
Member Author

@danielmackay, are you happy that I look at replacing these placeholders?

@danielmackay
Copy link
Member

danielmackay commented Oct 27, 2023

@danielmackay, are you happy that I look at replacing these placeholders?

@GordonBeeming - yes I'm happy for you to do that. Thanks for the suggestion. 😄

@jernejk
Copy link
Member

jernejk commented Oct 27, 2023

I have created a PR for this but it might not pass due to insufficient permissions.
#190

UPDATE: The PR can't be merged because of the #191 bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug A problem with existing functionality
Projects
Development

No branches or pull requests

3 participants