New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External images not working with lightbox, and not suitable for long term reliability. #2061

Open

2 tasks

theixdev opened this issue Nov 9, 2021 · 1 comment

Contributor

theixdev commented Nov 9, 2021

Cc: @adamcogan @tombui99 @pierssinclairssw @theixdev @zacharykeeping @tiagov8

Hi All,

It is of concern that external images (even SSW.com.au) are too volatile and it is better to store images within the git folder itself.

Additionally, the Gatsby module for creating lightboxes on image click does not function for images that are not in the git folder.

Create a rule to find images not stored in Git.
Fix images so that they are stored in Git.

theixdev mentioned this issue

🐛 External images not opening lightbox. SSWConsulting/SSW.Rules#729

Closed

Member

tiagov8 commented Dec 7, 2022

Can CodeAuditor look for images hosted externally?

Note: We already have a rule on that: https://ssw.com.au/rules/images-should-be-hosted-internally/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment